Provide pickup service point name for requests

Description

Because several aspects of mod-circulation resources need to be aware of ServicePoints, we need to make mod-circulation handle these natively.

This will include:

  • Creating a ServicePoint class for mod-circulation to use internally (similar to Item, User, etc)

  • Creating a ServicePointRepository class for abstracting the retrieval of ServicePoint objects

  • Creating the appropriate mock resources for testing

  • Other supporting infrastructure, following the current patterns employed by mod-circulation

Use case to be covered initially:

  • adding the SP name to the collection of requests endpoint (for the CSV export) for pickupServicePoint

Next in the following uses will be covered within the specific issues:

  • validation when creating/updating (POST/PUT) a request with pickupServicePoint (CIRC-152)


And finally:

  • checkInServicePoint/checkOutServicePoint validation during creating/updating (POST/PUT) a loan (CIRC-150)

  • checkInServicePoint/checkOutServicePoint validation during check-out by barcode (CIRC-154)

  • adding the SP name to the collection of loans endpoint (for closed loans view) for checkInServicePointId and checkOutServicePointId (CIRC-150)

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Jakub Skoczen November 5, 2018 at 1:10 PM

My original thinking was that all use cases would be addressed within this issue. But if the PR that Kurt has already issued addresses particular blockers and only some use cases listed I think we can move the remaining uses cases to https://folio-org.atlassian.net/browse/CIRC-150#icft=CIRC-150 and https://folio-org.atlassian.net/browse/CIRC-152#icft=CIRC-152 or create new issues for them and resolve it. What do you think?

Marc Johnson November 5, 2018 at 12:34 PM

Use case to be covered initially: adding the SP name to the collection of requests endpoint (for the CSV export) for pickupServicePoint

Is this the only use case within the scope of this issue, and others will be addressed in their own issues?

Done

Details

Assignee

Reporter

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created October 25, 2018 at 2:52 PM
Updated November 23, 2018 at 3:56 PM
Resolved November 9, 2018 at 8:31 PM
TestRail: Cases
TestRail: Runs

Flag notifications