[Draft] Edge-dcb Module submission self-evaluation

 Uses Apache 2.0 license

 Module build MUST produce a valid module descriptor

 Module descriptor MUST include interface requirements for all consumed APIs

 Third party dependencies use an Apache 2.0 compatible license

 Installation documentation is included

• -note: read more at https://github.com/folio-org/mod-search/blob/master/README.md

• Deployment is described shortly

Jira: [EDGEDCB-11] [Prep. for TC module submission] 5. Installation documentation is included - FOLIO Issue Tracker

 Personal data form is completed, accurate, and provided as PERSONAL_DATA_DISCLOSURE.md file

 Sensitive and environment-specific information is not checked into git repository

 Module is written in a language and framework from the officially approved technologies page

 Module only uses FOLIO interfaces already provided by previously accepted modules e.g. a UI module cannot be accepted that relies on an interface only provided by a back end module that hasn't been accepted yet

Integration with any third party system (outside of the FOLIO environment) tolerates the absence of configuration / presence of the system gracefully

Acceptable

 Sonarqube hasn't identified any security issues, major code smells, or excessive (>3%) duplication

 Uses officially supported build tools

https://github.com/folio-org/edge-dcb/blob/master/pom.xml#L25

https://github.com/folio-org/edge-dcb/blob/master/Dockerfile

 Unit tests have 80% coverage or greater and are based on officially approved technologies

• Module's repository includes a compliant Module Descriptor
  • -note: read more at https://github.com/folio-org/okapi/blob/master/okapi-core/src/main/raml/ModuleDescriptor.json

 Module includes executable implementations of all endpoints in the provides section of the Module Descriptor

INAPPLICABLE

Environment vars are documented in the ModuleDescriptor

• • -note: read more at https://wiki.folio.org/pages/viewpage.action?pageId=65110683

 If a module provides interfaces intended to be consumed by other FOLIO Modules, they must be defined in the Module Descriptor "provides" section

 All API endpoints are documented in RAML or OpenAPI

 All API endpoints protected with appropriate permissions as per the following guidelines and recommendations, e.g. avoid using *.all permissions, all necessary module permissions are assigned, etc.

• • -note: read more at https://dev.folio.org/guidelines/naming-conventions/ and https://wiki.folio.org/display/DD/Permission+Set+Guidelines

There are no endpoints defined in module descriptor.

https://github.com/folio-org/edge-dcb/blob/master/descriptors/ModuleDescriptor-template.json

 Module provides reference data (if applicable), e.g. if there is a controlled vocabulary where the module requires at least one value

For edge module, there are no prerequisites data. 

 If provided, integration (API) tests must be written in an officially approved technology

• • -note: while it's strongly recommended that modules implement integration tests, it's not a requirement
  • -note: these tests are defined in https://github.com/folio-org/folio-integration-tests

 Data is segregated by tenant at the storage layer

 The module doesn't access data in DB schemas other than its own and public

 The module responds with a tenant's content based on x-okapi-tenant header

INAPPLICABLE

 Standard GET /admin/health endpoint returning a 200 response

• -note: read more at https://wiki.folio.org/display/DD/Back+End+Module+Health+Check+Protocol

exposure:
  include:health,info,loggers

ACCEPTABLE

Module have the spring boot actuator dependency and health endpoint is enabled. It is accessible in local but unable to test it in rancher. 

https://github.com/folio-org/edge-dcb/blob/master/src/main/resources/application.yml#L23

https://github.com/folio-org/edge-dcb/blob/master/pom.xml#L100

 High Availability (HA) compliant

• • Possible red flags:
    • Connection affinity / sticky sessions / etc. are used
    • Local container storage is used
    • Services are stateful

 Module only uses infrastructure / platform technologies on the officially approved technologies list.

• • e.g. PostgreSQL, ElasticSearch, etc.