Date
Attendees
Goals
- Discuss PR process for UI modules and propose required steps prior to accepting PR.
- Discuss SonarQube Quality Gate required configuration and enforcement.
Helpful information to review prior to meeting:
- FOLIO-1049 - Getting issue details... STATUS
- FOLIO-1344 - Getting issue details... STATUS
- https://dev.folio.org/guides/code-analysis/
- https://docs.sonarqube.org/display/SONAR/Metric+Definitions
Discussion items
| Time | Item | Who | Notes |
|---|---|---|---|
| 5 min | Open tasks housekeeping | Anton | |
| 30 min | PR process for UI modules | The Team | 1) Lint must to pass - we do rules in place to turn it on. 2) yarn test → BigTest/Karma/ or Nightmare 3) Pact has no failures 4) Run these test while we don't have unit test : only 5 UI modules have int. test at the module level. yarn test-int → stop gap measure until SQ QualityGate must to pass including: If simple change then go ahead and merge; Complicated change ask for review; PR cannot be merged without approval by another dev. |
| 20 min | QualityGate | The Team | |
| 5 min | Next steps for BigTest implementation | The Team |