Definition of Done

Checklist

Feature/User Story

Sprint Demo/Review

Release

[M] Unit tests are written and are passing. At least 80% code coverage for new code is expected and 100% is preferred for critical code.

Y

[M] Pull request is created following existing templates for mod-kb-ebsco and ui-eholdings in folio.org and contain a .gif of feature implemented where its appropriate

Y

[M] Peer code review is performed and at least one developer from Ebsco and one developer from Scanbit team are requested for code review; code can be merged to master only when build passes and after peer approval

Y

[M] Fix reported code smells, security vulnerabilities, lint errors that are reported by Sonarqube and other tools in CI pipeline before merging code to master

Y

[M] Existing Unit tests and Integration tests within the module are maintained/implemented/improved and pass

Y

Microservice contract tests(pact) are created and integrated into CI pipeline – future requirement

Y

[M] Any configuration and/or build scripts are updated and tested

Y

[M] Build deployed successfully to snapshot or snaptshot-stable environment (test, integration etc.)

Y

[M] QA is performed and issues resolved

- Feature is tested against acceptance criteria

- Tests on supported browsers/devices/platforms pass (Chrome only for now and TBD)

Y

[M] Feature implemented meets acceptance criteria defined by PO/TL

Y

Regression tests pass – future requirement

Y

[M] Verify that PII stored is encrypted - TBD

Y

[M] verify compliance with GDPR – future requirement

Y

[M] Feature OK’ed by UX and complies with (PO's responsibility):

- https://ux.folio.org/docs/guidelines/

- WCAG 2.0 Level AA accessibility compliance
- Validate with Filip Jackobsen before coming with new design patterns in UX that’s not consistent with Stripes

Y

[M] Feature is accepted by PO
- Move the story to “in Review” when available on snapshot or snapshot-stable and assign it to PO who will review and demo it to PO and move it to Done if acceptable

Y

[M] Localization is taken into account in application code

Y

[M] No open critical bugs on any user stories

Y

[M] DoD of each user story, included in demo are met

Y

[M] All demoable features are demoed from the same shared environment – For most demos, this will be FOLIO environment (snapshot or snapshot-stable)

Y

[M] Releases are created following: https://dev.folio.org/guidelines/release-procedures/

Y

[M] Performance tests are created and pass – Example: All end user interactions < 2 seconds for 95 percentile or no degradation in response time for existing functionality - TBD (not applicable)

Y

[M] All critical bugs in backlog reported by QA, manual testing, UAT, PO etc. are fixed

Y

[M] User documentation is localized - TBD

Y