Requirements - MODORDSTOR-37 - Getting issue details... STATUS
Spike to determine whether the "first" and "last" fields in the collection schemas should be 0 or 1 based. Do we even need these fields? It doesn't look like other modules have them.
See https://github.com/folio-org/acq-models/pull/61#discussion_r244816230 for details
Investigation
- "first" and "last" fields are not being used in UI orders
- Multiple APIs are setting "first" and "last" field in collection in mod-orders-storage but those are never being used further.
- In daily standup, this was brought up and consensus was these fields were created when repositories were defined but these fields were never used in production.
Solution Proposal
Remove first and last field from example mod-orders-storage/examples/adjustment_collection.sample
Remove first and last field from schema mod-orders-storage/schemas/adjustment_collection.json
Remove reference to first and last field in storage module https://github.com/folio-org/mod-orders-storage/blob/master/src/main/java/org/folio/rest/impl/AdjustmentsAPI.java#L70-L77