Page Comparison

Today:

• Need approval of TCR-42
  • Only issue last time was waiting for PC approval; that has now happened.
  • No end-to-end tests provided, so that doesn't violate criteria.
  • Approved by lazy consensus.

TCR-43: mod-marc-migrations

• Jeremy Huff told Jenn Colt offline that he expects to have it ready by Wednesday.

TCR-45 mod-record-specifications

• Ingolf Kuss Finished the review, all criteria fulfilled except snapshot version dependence.  Dev lead said they will change that dependency before flower release.
• There is a pull request #76 to change that TCR criteria.   
  • Marc Johnson We currently have a disagreement on whether/what to change in the criteria.  Ingolf recommends we approve the TCR regardless.  Marc recalls TC preferring that we decide on the PR first.
    • Maccabee Levine Agree we should decide the PR before the TCR.  Started the conversation several times, there may be disagreement, but need to make a decision.
  • Julian Ladisch disagrees with softening the criterion, prefers to remove it entirely.
  • Marc Johnson it's there because it was originally desired.
  • Jenn Colt Criteria that requires the reviewer to make a subjective judgement are difficult, would rather remove the criterion.
  • Marc Johnson Given that using snapshot dependencies is common practice, does anyone feel strongly enough to oppose ditching the criteria entirely?
    • No objections raised.
  • Change accepted without disagreement.  Ingolf Kuss merged the PR and will change the other related file as well.
• Back to TCR-45.  Ingolf recommends acceptance.  No objections.
  • Approved by lazy consensus.

TCR-44

• Craig McNally First part is deciding about Go lang.  Second is approval of mod-reporting.
• Maccabee Levine Jakub suggested "I think there should be a presentation to the TC from DevOps regarding issues (or lack thereof) related to supporting Go in CI/CD and FOLIO deployments.", and then ok to to the TCR in parallel.
  • No disagreement on process.
  • Marc Johnson Should review this decision next time we review processes.
• Julian Ladisch will do the TCR review of TCR-44.
• Need presentation from DevOps.
  • Jakub Skoczen Maybe we should structure discussion about the criteria.
  • Craig McNally Agree.  Ask Julian to go through criteria, identify which items require discussion.
  • Marc Johnson Agree but suggest we say beforehand things that we know will fail.  Some gaps already known.
• Jenn Colt Let Julian get started on this, then note in Slack when we want to use a Wednesday discussion to talk about it.  Or schedule now.
  • Craig McNally We should schedule now, within timebox for initial review.  Wed 10/23 for review.

Last time:

mod-reporting, a Go rewrite of mod-ldp, has been submitted. As Go is not yet supported it requires work regarding static code checks, code coverage automation, etc.

We should first complete the existing TCR requests.

Should we merge the PR that removes the snapshot criterium from our module acceptance criterium? This will solve the issue with the TCR.

Depending on a SNAPSHOT version is bad practice. Maven rejects a release when trying to release a module with SNAPSHOT dependency. It is also bad practice during development because the build is not reproducible. However, as FOLIO libraries are provided as SNAPSHOT version only the modules are forced to use SNAPSHOT versions during development.

When merging the PR we can appove the submitted module without explaining why we overwrite the SNAPSHOT criterium.

Instead of removing the SNAPSHOT criterium it should be a requirement that can be ignored if reasonably justified.

A warning not to use a SNAPSHOT dependency is in the module release documentation for maven based modules: https://dev.folio.org/guidelines/release-procedures/#prepare-and-perform-the-source-release

We don't know how non-maven modules prevent SNAPSHOT dependencies.

It's up to the development teams how to prevent SNAPSHOT dependencies.

Go modul mod-reporting:

When accepted as a module we indirectly adopt Go as a language.

Should we first accept Go as a language including specific criteria regarding static code analysis, security, etc.?

In the past PoCs have been used to add new stuff to FOLIO without evaluation/approval.

We had been discussing the Go RfC for months.

Regarding adding the Go stack we need more feedback from the community.

• /wiki/spaces/DA/pages/416743762
• /wiki/spaces/DA/pages/475070465
• Some notes:
  • Met Thor team.  Met Oleksii's group.  
  • Developer documentation group: meetings with Khalilah, Terrence (NLA), John Coburn.
  • Identifying pages to be migrated.  Developing DDG membership & roles.
  • Local dev work, setting up env, trying single-server install, understanding different components.  Understanding developers' limiting factors.
  • Contract 6m contract ends in ~6wabout a week, personal things came up.  Won't be able to take the next contract.  Wrapping up, handing off.  Will do a "role in review".  Leave artifacts that might be beneficial.

Technical Council Sub-Groups Updates

Reminder(s)

• Review of open items, such as the need for decision log records and the application of the "Go" RFC.
  • Still need merge and decision log entry

Officially Supported Technologies (OST)

• Jenn Colt Delay is related to the devops discussion about Java.  Checked with Mike G. just before the meeting about whether it will cause an issue for Jenkins.
• Marc Johnson For some period of time we will need Jenkins agents on both versions of java, running concurrently.
• Jenn Colt Mike's question was about compatibility.  Whether a Java 21 build image will be compatible with Jenkins (on Java 8).
  • Marc Johnson Thought Jenkins was on Java 11.  But how long do we wait?
  • Jenn Colt OST discussion this Wednesday?
  • Sunflower release scope composition deadline was September 27, so that's our deadline.  Jenn Colt will let Mike know that.