Meeting Details

Date

Status

subtle	true
colour	Red
title	Draft

27 Apr 2022

Time

9:05am ET, 2:05pm UK, 3:05pm Germany

Location

Video Call in

FOLIO Slack: #erm-developers
Backup (Meet): https://meet.google.com/oei-okoc-eys

Previously

2022-04-13 ERM Weekly Delivery Update

References

JIRA Issue Board

Goals

ERM Sprint 138

Participants

Apologies

Discussion items

Time

Item

Notes

<5 mins

Introductions

Attendees / Apologies
Upcoming Availability - to end of Sprint 141

Call Priorities

Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-1986
/
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-1989

WIP

Expand

title	In Progress

ISSUE:
- Progress / Impediments:
- TODO:
- New unknowns:
- Help or input needed:
- ETA for review:

What progress or impediment on previously stated actions?
What's left to do?
Any new unknowns?
What help or input is needed?
When expected to be ready for review?

In Progress

Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2045
- Progress / Impediments:
  - none
- TODO:
  - update contentType to refdata
    - Add object with link to parent and hang refdata off that
    - Needs separate class with hasMany
  - from PR feedback - exclude owner on ermResource
  - update migrations for contentType
    - avoid adding and removing in the same commit
- New unknowns:

- NA
- Help or input needed:

- NA
- ETA for review:

- Mon
Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2059
- Progress / Impediments:
- TODO:
  - Changes to package schema, to make it acceptable from any source (not just Gokb)
  - Changes

to adaptorMay not need

- - to

change

- - ingest
- New unknowns:

whether ingest changes are needed will become clear once adaptor/schema changes

- NA
  - contentType query on ERM-2045
- Help or input needed

: none

- :
  - Recent example of schema update: https://github.com/folio-org/mod-agreements/pull/547
- ETA for review:

Thu

- Wed
Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-1986
/
Jira Legacy
server System

Jiratests

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-1989
- Progress / Impediments:
  - Reviewed progress with Gill
  - Some changes requested around modal functionality and styling, requiring refactor
  - Peer reviewed with Ethan
- TODO:

enable preview

submitHandler to map between API / data model and presentation

works if selecting checkbox but not label

needs more investigation

- - implement form submit handler
  - remove duplication of 'journal' (pub type) in source
  - add pending notice to Move identifiers screen if user wants to move more identifiers
  - tests and linting
- New unknowns:

potential new checkbox/label bug in Stripes

- - How to handle going back to move more identifiers (as update is asynchronous) and removing pending identifiers
    - potentially check the jobs, though that would involving parsing json files
- Help or input needed:

Presentation is different from UI = need to check with Gill

- ETA for review:

- Fri
Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2060
- ~~Progress / Impediments:~~
- ~~TODO:~~
  - ~~tests~~
- ~~New unknowns:~~

- NA
- ~~Help or input needed:~~
  - ~~Testing lists of key-value pairs~~
    - ~~just test for presence of the strings in the DOM~~
  - ~~Testing Dates~~
    - ~~Behaviour of line break seems to be inserted when using FormattedDateTime~~
    - ~~Tried: insert   instead of " "~~
    - ~~Try separately processing FormattedDate and FormattedTime, manually inserting space~~
    - ~~Check on #stripes-testing~~
- ~~ETA for review:~~
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2066
- Context
  - tiny stripes-connect symptom
  - want to migrate tags to react query to resolve this
  - end up with cascading effect ... need to change viewRoute as well
- Progress:
  - agreements and platform routes use react query now as functional components: tags working well with some marginal performance gains
  - pattern exists to reuse in other components
  - not done some as they are very convoluted logic (eg, orderlines chunking) or don't use tags (eg, ui-local-kb-admin)
  - create and edit routes are not using tags, so are not touched yet
  - current state is a hybrid of stripes-connect and react
- TODO:
  - licenses 2-3 days + comprehensive QA (esp cross-route interactions)
  - add stub Jira issue for other components/routes that need to be refactored / migrated
  - TO PARK: refactor fully away from stripes-connect is much bigger

Pending

Expand

title	Blocked

ISSUE
- Blocking conditions
- Action needed

Are the blocking conditions still relevant?
What action is needed to unblock, and by whom?

Expand

title	Needs Elaboration

ISSUE:
- Who / When:
- ETA Ready for Dev:

Who needs to be involved in the elaboration process?
What is the timeframe for getting input?
When is the issue expected to be ready for development?

Expand

title	Sprint Backlog

Who is picking up what next?
When is next issue expected to start / complete?
Anything needed to start next issue (dependencies or clarifications)?

Blocked

NA

ISSUE
- Blocking conditions
- Action needed

Needs Elaboration

NA

ISSUE:
- Who / When:
- ETA Ready for Dev:

Sprint Backlog - Next Up

Claudia:

Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-

1313

2046

Ethan:

Jira Legacy

server	System Jira
serverId	01505d01-b853-3c2e-90f1-ee9b165564fc
key	ERM-2066

Monireh:

Jira Legacy

server	System Jira
serverId	01505d01-b853-3c2e-90f1-ee9b165564fc
key	ERM-2081

Peter:

- Who / When: Owen
  - Move ERM-286 to task defining UXPROD-3591
  - Preserve ERM-2046 for ERM-287, ERM-288 and ERM-289
  - Split other subtasks into separate stories for different related subtasks
- ETA Ready for Dev:

Sprint Backlog - Next Up

Claudia: babel-eslint dependency change and regression testing
Ethan: ERM-2085
Monireh:
Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-

2045

Domain modelling choice needs to be clarified

package hasMany contentTypes refdata with multiple types has been done as string
potential duplication of existing refdata - should they be in lockstep or

Options TODO

if string: no change

if refdata: add refdata (0.5d)

if lockstepped: more effort to ensure consistency (1d)

2081
Peter: NA

At Risk

What is now at risk of not being started this sprint?
Do any of these take priority over other sprint backlog items?

Sprint Backlog - to follow

RTL

Sprint Backlog - At Risk

Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-

2066

2081

In Review

Any impediments to review or QA?
Any useful context, implementation choices or limitations for the reviewer/tester to know ?

Code Review:

Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2060
Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-

2069

2076
Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-

2070

1313
Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-

2071

1322

QA / UAT

Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-778
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2044
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2048
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-1850
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2073
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2079
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2078
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2068
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2086

Bugfix Cycle

NA

Release Candidates

What has passed QA since last dev call?
What has been closed since last dev call?

Accepted

For Lotus Bugfix: release complete but held For Release for testrails.

Jira Legacy
server System

Jira

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-1979
Jira Legacy
server System

JiraOther

JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2043

Closed: Morning Glory R2022.2

Features

RTL / Other Tests

Other

Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2069
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2070
Jira Legacy
server System JIRA
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc
key ERM-2071

<10 mins

AOB

New Issues

Added to sprint

NA

Not added to sprint

NA

Claudia Malzer topick up babel-eslint issues (based on STRIPES-742):
Jira Legacy
server System

Jira

JIRA
jqlQuery project=ERM AND issuekey>=ERM-2095 AND issuekey<=ERM-2104
serverId 01505d01-b853-3c2e-90f1-ee9b165564fc

keyERM-1958

Not added to sprint

ERM-2085 to be added to next sprint, and partialluy dealt with as part of ERM-2066

Other

Reschedule: Sprint Planning (sprint 139) is Tue 3 not Mon 2 May (UK public holiday)
To watch: eresources search and filter load time (review any feedback in Morning Glory bug fest)

Versions Compared

Old Version 1

New Version Current

Key

Meeting Details

Goals

Participants

Apologies

Discussion items

In Progress

Blocked

Needs Elaboration

Sprint Backlog - Next Up

Sprint Backlog - Next Up

Sprint Backlog - to follow

Code Review:

QA / UAT

Bugfix Cycle

Accepted

Closed: Morning Glory R2022.2

Features

RTL / Other Tests

Other

New Issues

Added to sprint

Not added to sprint

Not added to sprint

Other

Page Comparison

Versions Compared

Old Version 1

New Version Current

Key

Meeting Details

Goals

Participants

Apologies

Discussion items

In Progress

Blocked

Needs Elaboration

Sprint Backlog - Next Up

Sprint Backlog - Next Up

Sprint Backlog - to follow

Code Review:

QA / UAT

Bugfix Cycle

Accepted

Closed: Morning Glory R2022.2

Features

RTL / Other Tests

Other

New Issues

Added to sprint

Not added to sprint

Not added to sprint

Other