renewal failure messages are not internationalized

Description

Overview:

Renewal failure messages are not internationalized in src/withRenew.js::getMessage(). It may be necessary to update src/components/Loans/OpenLoans/helpers/isOverridePossible/overridePossibleMessages.js as well.

Steps to Reproduce:

  1. Log into Snapshot

  2. Check out Item 1 to Patron 1

  3. In settings, modify the loan policy for the created loan to have a Number of Renewals Allowed of 1 

  4. Navigate to the Users app and open the record for Patron 1, and open the patron's open loans

  5. Select the newly created loan and renew the item twice

 

Expected Results:

When the second renewal is attempted an error popup is shown and the backend sends a 422 HTTP status code with JSON including the "code" property:

Actual Results:

The "code" property defined in the error.schema is missing:
https://github.com/folio-org/raml/blob/raml1.0/schemas/error.schema

Additional Information:

  • The code property is not included in any circulation/renew-by-barcode responses with a 422 status code. These other cases will likely need separate tickets created.  

  • I am not certain that there are existing error codes that should be included in these responses. 

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

2

Checklist

hide

TestRail: Results

Activity

Show:

Nika Mindadze January 12, 2024 at 1:07 PM

I was able to reproduce  the issue, alert is translated to the language of choice 

Irina Pokhylets January 10, 2024 at 1:05 PM

could you please check if it is still an issue? 

Amelia Sutton July 6, 2023 at 5:34 PM

I've updated this ticket to better reflect the issue being described. I am unsure how to find the error codes that should be returned in these 422 responses so I don't know that they exist at this time. 

Khalilah Gambrell December 22, 2022 at 2:14 PM

Hey   and . I also added this to the Volaris ui-only backlog. It is not a high priority. 

Khalilah Gambrell December 22, 2022 at 12:13 AM

May no longer be the case. Need to verify. 

Details

Assignee

Reporter

Priority

Development Team

Volaris

Release

Trillium (R2 2025)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created April 9, 2019 at 12:53 AM
Updated yesterday
TestRail: Cases
TestRail: Runs