Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Generalise <SearchAndSort>

Description

Although the <SearchAndSort> component is now working, and enabling ui-users to behave the same as the old monolithic version, it need to be generalised before it can be used for other modules: at present it has a bunch of user-specific stuff wired into it, which all needs to be parameterised.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike Taylor November 9, 2017 at 11:11 AM

I simplified the API a little: there is no longer any need to pass the parsed URL query into <SearchAndSort> component, which now gets it from the react-router props itself. See https://github.com/folio-org/ui-users/pull/131/commits/0e6be8f4fe3641e2c73c4d0b5d588558a9b7752b

Mike Taylor November 3, 2017 at 3:44 PM

As of https://github.com/folio-org/ui-users/pull/117 I am declaring this basically done.

Mike Taylor November 1, 2017 at 6:45 PM

A ton of progress on this, mostly to do with parameterising various aspects of the generic code, which still has a bunch of Users-module-specific stuff in it. I should probably have filed some sub-issues along the way.

Done

Details

Assignee

Reporter

Labels

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created October 31, 2017 at 1:46 AM
Updated December 1, 2017 at 6:16 PM
Resolved November 3, 2017 at 3:44 PM
Configure
TestRail: Cases
TestRail: Runs