migrate from react-hot-loader to react-fast-refresh

Description

Remove react-hot-loader dependency, or replace it by react-fast-refresh.

For details see STRIPES-725.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Marc Johnson April 19, 2022 at 3:52 PM

It doesn't make any sense to me that this is classified as a bug, and likewise it thus doesn't make any sense that it have an RCA attached.

I support that stance.

(I was hesitant to bring up the changing of the issue type, as I've not had success with that suggestion in the past. I'm more than happy to support that solution too)

Zak Burke April 19, 2022 at 3:09 PM

, Michał's clever implementation of react-fast-refresh in stripes-webpack mean this issue amounts to nothing more than "remove an unused development-only dependency". There is nothing more to it. It doesn't make any sense to me that this is classified as a bug, and likewise it thus doesn't make any sense that it have an RCA attached.

True, RHL hasn't been maintained for a while, and some of its transitive deps have security issues which thus infect our apps. But all of that really misses the point of this work, which is to remove some dev-dependency cruft that never shipped in production anyway.

Marc Johnson April 19, 2022 at 2:40 PM

This is currently classified as a requirements change.

[STRIPES-725] seems to suggest this was a security issue.

The two categorisations don't line up for me. I don't consider a reaction to a potential exploit as a change of the expectations of how the software will support a task.

Could it be worth having a RCD group specifically for security fixes, rather than other classifications?

Marc Johnson March 29, 2022 at 6:01 PM

is this something we need to address for Lotus as part of Lotus Bugfix release - or is this work for Morning Glory.

has assigned [STRIPES-725] Morning Glory. I reckon that means this issue is also for Morning Glory.

Charlotte Whitt March 29, 2022 at 12:55 PM

- is this something we need to address for Lotus as part of Lotus Bugfix release - or is this work for Morning Glory.

When checking STRIPES-725 Replace react-hot-loader - an umbrella issue - it has no release scheduled.

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Prokopovych

Fix versions

Release

Morning Glory (R2 2022)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created March 25, 2022 at 3:03 PM
Updated June 27, 2022 at 7:46 PM
Resolved April 21, 2022 at 8:17 PM
TestRail: Cases
TestRail: Runs