Claims Returned Confirmation Does Not Warn of Possible Open Requests

Description

Overview:

According to the test case: https://foliotest.testrail.io/index.php?/tests/view/932012 the Claims Returned confirmation modal in a user's open loan list should warn the user that there may be open requests on an item, or indicate how many open requests there are, if the user has the right permissions. While this does occur in the loan detail view when claiming returned, there is no message when invoking claims returned from the list. See attached screenshots.
Steps to Reproduce:

  1. Open https://bugfest-kiwi.folio.ebsco.com/users/3ba42363-bdfd-4b6b-8fdb-cf7970c589b1/loans/open as a user with the Users: loans claim returned and no requests permissions

  2. Select the check box next to the loan you wish to claim returned

  3. Click "Claim returned"

Expected Results:

The claim returned confirmation modal should appear and feature a message indicating that there may be open requests on the item.

Actual Results:

The claim returned confirmation appears but has not such message.

Additional Information:
URL:
Interested parties:

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

1

Checklist

hide

TestRail: Results

Activity

Show:

Brooks Travis April 12, 2022 at 12:20 PM

Let’s just close it as “works as expected” and I’ll update the test case.

Marc Johnson April 12, 2022 at 8:52 AM

Given that we are past the end of the bug fixing period for Lotus and this is marked as P3, can it be deferred to Morning Glory?

Matt Connolly April 7, 2022 at 12:38 PM

 OK, then is there anything we need to do with this issue, or can it be closed?

Brooks Travis April 6, 2022 at 9:24 PM

 Sorry, I did miss it. I'd be in favor of updating the test case to reflect the way it currently functions. It just doesn't match with the existing test case.

Matt Connolly March 30, 2022 at 5:31 PM

 I think the reason for the discrepancy is that the button on the loan detail view always acts on a single item, while that on the list can potentially mark many items in a single action (in the code, it's referred to as "bulk claim returned"). In the bulk case, a single warning about open requests might not be very helpful, as it wouldn't identify the specific item or items in question. There is a column in the loan table that shows number of requests for each item, though.

Given that this is an alert for 1+ records, should the warning about potential open requests appear only when a single item is being updated? Or should it always appear if there are open requests for any items in the batch, simply stating that "some items" may have open requests? 

Won't Do

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Prokopovych

Release

Lotus (R1 2022) Bug Fix

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 29, 2021 at 9:08 PM
Updated April 12, 2022 at 1:03 PM
Resolved April 12, 2022 at 1:03 PM
TestRail: Cases
TestRail: Runs