correctly load URLs with filters containing dynamic filterConfig values

Description

Test case:
Go to Users
Select a patron group filter
Then refresh the page.
After the refresh, the filter should be applied.

ui-users/Users.js updates filterConfig in componentWillUpdate but that means it can’t set state.filters so that the UI would reflect the URL. This causes URLs like http://localhost:3000/users?filters=pg.staff not to load correctly while http://localhost:3000/users?filters=active.Active (the active values are hard-coded) work fine.

Same for the Material Type filters in ui-items/Items.js

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie Breaux April 5, 2018 at 7:46 AM

Ah - I understand now. Doublechecked it, and the filters are working properly after a page refresh. So all is good.

Roman Ruiz-Esparza April 4, 2018 at 11:54 PM

Thanks. Just to clarify, the bug was that after refresh, the filter would not be applied.

Ann-Marie Breaux April 4, 2018 at 10:04 PM

Filter is actually applied, and you go from a blank results list to a filtered results list, without even having to refresh the page. I'm assuming that's OK, so closing the ticket.

Ann-Marie Breaux April 4, 2018 at 3:52 PM

Thanks, I've added the test case up top, and we'll test as soon as we can. The existing description was too technical for me!

Roman Ruiz-Esparza April 4, 2018 at 3:23 PM

The status is correct; it is not in code review.
Test case: Go to Users, select a patron group filter, then refresh the page. After the refresh, the filter should be applied.

Done

Details

Assignee

Reporter

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created July 18, 2017 at 4:26 PM
Updated July 3, 2019 at 8:25 PM
Resolved April 4, 2018 at 10:05 PM
TestRail: Cases
TestRail: Runs