Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Sending "new fee/fine" and "payment" notices when "Notify patron" unchecked

Description

Preconditions:

  1. Under Settings > Users > Fee/fine

    1. Owner > Enter required data.

    2. Manual charges > Select owner, and enter default charge notice and default action notice. (You can also setup specific notices for specific types of charges.)

  2. Setup user with email address that you have access to.

Steps to reproduce for a new fee/fine charge:

  1. Create a new fee/fine.

  2. Enter the required data.

  3. Uncheck the "Notify patron" checkbox.

  4. Press the "Charge only" button.

Steps to reproduce for a payment of fee/fine charge:

  1. Go to user with fee/fine

  2. Select "x open fee/fines" link.

  3. Uncheck the "Notify patron" box.

  4. Press the "Pay" button.

  5. You will get a confirmation modal.

  6. Confirm the payment.

  7. (The pay modal will flash behind the confirmation, with the "Notify patron" box check marked again.)

Expected results:
Patron will NOT receive a notice.

Actual results:
Patron receives a notice regardless of the unchecked "Notify patron" checkbox.

Holly's additional notes:

  • When I retested these steps at 8:00 PM on December 12th, I received this error

  • As part of Q4 BugFest, Holly is testing several fee/fine features at https://bugfest.folio.ebsco.com. When a new fee/fine is charged, a "charge" notice is being sent to the patron even if the user has unchecked the "Notify patron" box on the "New fee/fine" page. Also, when a payment is made, an "action" notice is being sent to the patron even if the user has unchecked the "Notify patron" box on the "Pay fee/fine" modal. This issue is related to , which was originally worked on by Vega.

Darcy's additional notes:

  • When I retested these steps on December 12th (earlier than Holly above) and again December 13th at 11 am, I did not receive the error that Holly included above.

  • I was able to reproduce on folio-snapshot.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

5

Checklist

hide

TestRail: Results

Activity

Show:

Holly Mistlebauer January 30, 2020 at 8:59 PM

This is working now. Thanks much!

Holly Mistlebauer January 30, 2020 at 8:58 PM

: I sent you a Slack message about this already, but I also want to put this message in JIRA...

It looks like the issue is totally fixed! When I tested this, the notifications for charges arrived immediately but the notifications for payments never showed up. I just checked my Yahoo! account and the payment notifications were sitting there. So I retested TEST3 and the payment notification appeared immediately. You must have been very confused about why this wasn't working for me. Sorry about that.

So, we don't need to meet tomorrow. I will close this issue now.

Thanks,
Holly
cc:

Holly Mistlebauer January 30, 2020 at 7:00 PM

: Hi. I just tested this at https://folio-snapshot.aws.indexdata.com/. It is half fixed. On January 20 i attached the steps for two scenarios that were not working (Test3-Steps.pdf and Test4-Steps.pdf)...

  • Test3-Steps.pdf shows the situation where "Charge & Pay Now" is used for a newfee/fine, with the charge notice not selected and the payment notice selected. This scenario still does not work.

  • Test4-Steps.pdf shows the situation where "Charge & Pay Now" is used for a new fee/fine, with the charge notice selected and the payment notice not selected (the opposite of Test3-Steps.pdf). This scenario is now working correctly.

The scenario in Test3-Steps.pdf is the one that is going to be used ~90% of the time.

If you would like for me to do a demo for you please let me know. I am available on Friday morning from 10:00-noon US Eastern time and Monday morning 9:00-10:00 US Eastern time.

Thanks,
Holly

Holly Mistlebauer January 20, 2020 at 9:54 PM
Edited

: Hi! I just re-tested this at https://folio-snapshot.aws.indexdata.com/ per your Slack message. The problem described in Test-2-Steps.pdf has been fixed, but the problem described in Test-1-Steps.pdf still exists. Let me describe the problem to you...

  • With Charge & Pay Now, two transactions take place: New Fee/Fine and Pay Fee/Fine.

  • Both transactions will send a patron notice if Settings==>Users>Fee/Fine==>Manual charges have notices set up for both charges and actions.

  • If appears that whatever the "Notify patron" flag is set to on New Fee/Fine is what is also used for Pay Fee/Fine. This should not be happening because Pay Fee/Fine has it's own "Notify patron" flag.

  • The proof of this is that when the New Fee/Fine "Notify patron" flag is checked and the Pay Fee/Fine "Notify patron" flag is unchecked, both notices are sent (when only the charge notice should be sent). And when the New Fee/Fine "Notify patron" flag is unchecked and the Pay Fee/Fine "Notify patron" flag is checked, no notice is sent (when the action notice should be sent).

  • New attachments Test3-Steps.pdf and Test4-Steps.pdf show the steps for both cases described in the above bullet.

cc:

Holly Mistlebauer January 17, 2020 at 7:51 PM

and : I double checked https://folio-snapshot.aws.indexdata.com/. You need to successful press the CONFIRM button on the Pay Fee/Fine Confirmation modal before the error described in Test-1-Steps.pdf occurs. Right now when you press the CONFIRM button you get the system error.

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Story Points

Sprint

Development Team

Vega

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created December 12, 2019 at 3:58 PM
Updated April 7, 2020 at 8:14 PM
Resolved January 30, 2020 at 8:59 PM
TestRail: Cases
TestRail: Runs