Request preferences on Edit and View user record
Description
Environment
Potential Workaround
Attachments
has to be done after
has to be done before
relates to
Checklist
hideTestRail: Results
Activity
Cate Boerema October 30, 2019 at 11:27 AM
Oh! Yes, that's different from how the other teams I work with do things. I'll keep that in mind for Spitfire.
Yurii Danylenko October 29, 2019 at 5:07 PM
@Cate Boerema, thank you for review. This story as long as https://folio-org.atlassian.net/browse/UIU-1290 were not be ready for PO review, as we have a convention in our team that developer checks his story on remote env(folio-testing or folio-snapshot) and after that assigns it on PO to be reviewed. I think the fact that story was in "Review" column confused you. Regarding "The Delivery address re-appears" hot fix was merged today. Also I will add suggested improvements and notify you when they are available on "folio-testing" env. Sorry for any inconvenience.
Cate Boerema October 29, 2019 at 2:17 PM
@Yurii Danylenko I see a few issues (see comments in story body). I also see some odd behavior when I do this:
Create a user and select a default delivery address of, say, Claim
Save user
Edit user and uncheck Delivery
Re-check Deliver
The Delivery address re-appears
Actual: The Delivery address menu doesn't have anything selected but it is possible to save the record (which is strange because this is a required field). Then, in the view mode of the saved record, the Delivery address is actually populated with the previously selected address type (Claim, in my example).
Expected: Either of these would be fine, I think:
Re-checking Delivery should auto populate the Delivery address menu with the previously selected address (Claim) OR
Re-checking Delivery should leave the Delivery address menu blank and validation should prevent save of the record until a new Delivery address is saved
Cate Boerema October 29, 2019 at 1:55 PM
This isn't a failed scenario, but same comment as I made on https://folio-org.atlassian.net/browse/UIU-1290#icft=UIU-1290. Now that I see this in the User record, I think the "default service point" (which is really the default pickup service point for requests) might get confused with the default service point for login which can be specified in the Service points accordion. I think a couple of tweaks might help clarify this:
Can we bold the Request preferences label or otherwise make it more prominent so it's clear that all these settings really pertain to requests?
Can we please change the label from "Default service point" to "Default pickup service point"?
Unrelated, but, while you are in there maybe you can unbold the FOLIO number label?
Another unrelated formatting issue which only applies on the edit view: "FOLIO password" label is bold. Can we unbold that please?
Purpose: The purpose of this story is to enhance the user record so that it is possible to specify request preferences. This will drive functionality in the Requests app.
User stories:
As a FOLIO administrator
I want to be able to specify which patrons are allowed to create delivery requests
Because not all patrons should be able to do this
As a patron who is allowed to create delivery requests
I want requests in FOLIO to default to my preferred delivery address
So that when I am requesting for delivery, FOLIO knows which address to use
As a patron
I want requests in FOLIO to default to my preferred pickup service point
So that when I am requesting for hold shelf pickup, FOLIO knows which pickup service point to use without my having to specify (this will save patrons a click when they are creating requests via discovery and, when staff are creating requests directly in FOLIO, it will give them valuable information about which pickup service point should be used)
Scenarios:
Scenario :check_mark:
Given the user record
When editing
Then a new group of field should be added called "Request preferences" as shown in the linked wireframes
Scenario CB: Not applicable to this story since this is now about edit only
Given the Request preferences grouping
When creating a new record
Then:
Hold shelf should be checked and disabled (all patrons get the hold shelf option)
Deliver should be unchecked
Scenario
Given the Hold shelf checkbox
When checked (as is always the case per scenario 2)
Then a "Default service point" menu should display :check_mark:
Contains all service points for which pickup location = yes :check_mark:
Displayed in alphabetical order :check_mark:
Optional :check_mark:
Default = "Select service point" :check_mark:
It should always be possible to revert to unselected ("Select service point") option :check_mark:
Scenario :check_mark:
Given the Delivery checkbox
When unchecked
Then there are no further options possible as shown here: https://drive.google.com/file/d/1AUwsNrJm9UrBNiuhIdgmE7y0LeITY3IJ/view?usp=sharing
Scenario
Given the Delivery checkbox
When checked
Then:
"Fulfillment preference" menu should display: :check_mark:
Contains: Delivery and Hold shelf :check_mark:
Hold shelf is default :check_mark:
"Default delivery address" menu should display: :check_mark:
Contains all address types for which an address has been specified in the user record :check_mark:
Optional Required if Delivery = Y CB: Changing this to required as we don't want to be in a situation where a delivery request is created and we don't have an address :check_mark:
Default = "Select delivery address" :check_mark:
Mockups: https://drive.google.com/drive/folders/1lqjdblpO_3wFLYcZdR4jabGCmp0iFsmC (now including mockups for the view mode)