Add Closed Library Date Management to Service Point for Hold Shelf Expiration

Description

Purpose: Add Closed library date management menu to service point for hold shelf expiration date calculation (see https://folio-org.atlassian.net/browse/UIREQ-246#icft=UIREQ-246 for details).

User story:
As a librarian
I want to be able to set what happens when a hold shelf expiration date/time falls on a date when the service point is closed
so that I can communicate that to the patron

Scenarios:

  1. Scenario

    • Given a service point at Settings > Tenant > Service points

    • When Pickup location = Yes

    • Then "Closed library date management for hold shelf expiration expiration date calculation" menu should display

  2. Scenario

    • Given Hold shelf expiry period

    • When specified in days, weeks or months

    • Then "Closed library date management for hold shelf expiration expiration date calculation" menu should contain:

      • Keep the original date

      • Move to the end of the previous open day

      • Move to the end of the next open day

  3. Scenario

    • Given Hold shelf expiry period

    • When specified in minutes or hours

    • Then "Closed library date management for hold shelf expiration expiration date calculation" menu should contain:

      • Keep the original date/time

      • Move to the end of the current service point hours

      • Move to the beginning of the next open service point hours

See attached mockup

Environment

None

Potential Workaround

None

Attachments

2
  • 07 Dec 2022, 10:12 AM
  • 04 Aug 2020, 10:36 AM

Checklist

hide

TestRail: Results

Activity

Show:

Nika MindadzeDecember 7, 2022 at 10:12 AM

  tested the ticket everything works fine,  I also have attached the video

Priyanka TeralaDecember 6, 2022 at 5:20 AM

 
The changes of this ticket are available on shanpshot - https://folio-snapshot.dev.folio.org/

Moving this ticket for your review.

Tim AugerNovember 24, 2022 at 4:55 PM

Cool. Thank you!

Priyanka TeralaNovember 24, 2022 at 3:46 AM
Edited

Thank you for the confirmation,  

We had a discussion this morning internally within the team.

Below are the conclusions of the discussion -

1. UI will always ensure to have a default value - which means the drop is always pre-filled with 

  • default value (Keep current date) when the add service point form is first loaded

  • already chosen/set value when edit service point form

2. BE will also hold a default value (Keep current date)

3. Having said that, setting a default value implicitly behaves like a required field. Hence,

  • UI - no red asterisk needs to be populated beside the drop down ("Closed library date management for hold shelf expiration date calculation") label.

  • BE - the field will hold a default value but will not be marked as required.

and If needed, please correct/add the mentions that of BE.

and Please let us know if any objections or modifications needed in the above stated approach.

cc  

Tim AugerNovember 23, 2022 at 7:59 PM

I received feedback from one of our main POs and I think it's a good choice. As we discussed this morning, the hold shelf expiration calculation should be required and the default should be set to "Keep the original date". The reasoning is to not change existing behavior and allow libraries to introduce it when they want. 

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Volaris

Release

Orchid (R1 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created April 2, 2019 at 9:09 AM
Updated December 15, 2022 at 6:23 AM
Resolved December 9, 2022 at 1:12 PM
TestRail: Cases
TestRail: Runs

Flag notifications