Hold Shelf Expiration Date Should Respect Closed Library Dates
Description
Environment
None
Potential Workaround
None
has to be done after
relates to
Checklist
hideTestRail: Results
Activity
Show:

Nika Mindadze February 9, 2023 at 1:07 PM
you can check it

Tim Auger January 30, 2023 at 12:51 PM
are you able to test this soon? Or, is there a blocker?

(OLD ACCOUNT) Erin Nettifee January 27, 2023 at 6:55 PM
or others can you confirm if any changes for are happening in the Request app UI? It looks like this is testing that the implemented back-end behavior works as expected - I am working on the end-user documentation piece for docs.folio.org and just want to make sure I'm not missing any updates in the Requests app itself.

Giorgi Ninua December 20, 2022 at 9:53 AM
Please take a look and check..

Priyanka Terala December 20, 2022 at 4:32 AM
Thank you for confirming!
In that case, I think it is something that will have to take up.
Done
Assignee

Reporter

Labels
Priority
Story Points
1
Sprint
None
Development Team
Volaris
Release
Orchid (R1 2023)
TestRail: Cases
Open TestRail: Cases
TestRail: Runs
Open TestRail: Runs
Created April 2, 2019 at 8:46 AM
Updated February 13, 2023 at 1:10 PM
Resolved February 13, 2023 at 1:10 PM
TestRail: Cases
TestRail: Runs
Purpose: We implemented the hold shelf expiration date setting as part of CIRC-194. This works great except that it is not respecting the closed library dates when setting the date. Since institutions want to put the hold shelf expiration dates into their patron notices, it would be best if those dates landed on a day the library was actually open.
User story:
As a patron who has received a message that my requested item is awaiting pickup
I want to be given a request expiration date that is a day the service point is open
So I don't plan to pick it up on a given date only to find the service point is closed
NOTE: Closed library due date management has already been implemented for calculating due dates. See: UICHKOUT-451 for details
Scenarios:
Long-term expiry periods (Months|Weeks|Days):
Scenario
Given Hold shelf expiry period, which has Expiry period = X Months|Weeks|Days AND Closed Library Date Management = Keep the original date
When Hold shelf expiration date/time is automatically set on a request (see CIRC-194 for details on when that is set)
When request Pickup service point is Service Point ID SPID-1
If SPID-1 is determined to be CLOSED for system-calculated hold expiration date
Then the hold shelf expiration date should remain unchanged from system calculated hold shelf expiration date, and the hold shelf expiration time should be 11:59:59PM*
Scenario
Given Hold shelf expiry period, which has Expiry period = X Months|Weeks|Days AND Closed Library Date Management = Move to the end of the previous open day
When Hold shelf expiration date/time is automatically set on a request (see CIRC-194 for details on when that is set)
When request Pickup service point is Service Point ID SPID-1
If SPID-1 is determined to be CLOSED for system-calculated hold expiration date
Then the hold expiration date/time stamp should be changed to 11:59:59PM* for the closest previous Open=true day for SPID-1
Scenario
Given Hold shelf expiry period, which has Expiry period = X Months|Weeks|Days AND Closed Library Date Management = Move to the end of the next open day
When Hold shelf expiration date/time is automatically set on a request (see CIRC-194 for details on when that is set)
When request Pickup service point is Service Point ID SPID-1
If SPID-1 is determined to be CLOSED for system-calculated hold expiration date
Then the hold expiration date/time stamp should be changed to 11:59:59PM* for the closest next Open=true day for SPID-1
*Note: Should be the equivalent of 11:59:59PM for the tenant's local timezone.
Short-term expiry periods (Hours|Minutes):
Scenario
Given Hold shelf expiry period, which has Expiry period = X Hours|Minutes AND Closed Library Date Management = Keep the original date/time
When Hold shelf expiration date/time is automatically set on a request (see CIRC-194 for details on when that is set)
When request Pickup service point is Service Point ID SPID-1
If SPID-1 is determined to be CLOSED for system-calculated hold expiration date/time
Then the hold shelf expiration date should remain unchanged from system calculated hold shelf expiration date
Scenario
Given Hold shelf expiry period, which has Expiry period = X Hours|Minutes AND Closed Library Date Management = Move to the end of the current service point hours
When Hold shelf expiration date/time is automatically set on a request (see CIRC-194 for details on when that is set)
When request Pickup service point is Service Point ID SPID-1
If SPID-1 is determined to be CLOSED for system-calculated hold expiration date/time
Then the hold shelf expiration date should be changed to the endTime of the current service point for SPID-1 (i.e., truncating the hold shelf expiry period)
Scenario
Given Hold shelf expiry period, which has Expiry period = X Hours|Minutes AND Closed Library Date Management = Move to the beginning of the next open service point hours
When Hold shelf expiration date/time is automatically set on a request (see CIRC-194 for details on when that is set)
When request Pickup service point is Service Point ID SPID-1
If SPID-1 is determined to be CLOSED for system-calculated hold expiration date/time
Then the hold shelf expiration date should be changed to the earliest SPID-1 startTime for the closest next Open=true available hours for SPID-1 (Note that the system needs to logically consider 'rollover' scenarios where the service point remains open for a continuity of hours that flow from one system date into the next - for example, a service point that remains open until 2AM; then reopens at 8AM. In such a scenario, the system should consider the '...beginning of the next open service point hours' to be 8AM. <NEED TO CONSULT WITH SEAN THOMAS AND/OR VEGA ON HOW THIS WAS EVENTUALLY HANDLED>