Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Intermittent: Error cancelling request ("Cannot edit closed request")

Description

CB: Matt Reno figured out how to repro this - YAY!

Steps to repro:

  1. Create a request

  2. From the pane header dropdown, select Cancel request

  3. Click the cancel button a second or third time while waiting for the popup to close

Actual: Error generated

Expected: One way to address this would be to disable the cancel button after clicked and show a loading indicator while it does the actual cancellation

Additional info: After clicking OK, the request is, indeed, cancelled

-------- OLD DETAILS PROBABLY NO LONGER RELEVANT ----------------

Screenshot of request, in case that's useful:

2019-09-13 CB: I saw this again today in folio-snapshot while cancelling this record. It was the one and only request in the system. The error pops up but when you click it away, the request is indeed cancelled.

2019-09-20 CB: saw this today during BugFest testing and recorded this: https://youtu.be/4UgBmbTLV6I

2019-10-25 Reproduced this again today between 11:40 and 11:46 am CET. We have logs for the day (attached) which we can investigage says the error is definitely coming from the backend and, it looks like the UI may be doing something twice or in two parts.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

7
  • 25 Oct 2019, 02:48 PM
  • 25 Oct 2019, 02:44 PM
  • 25 Oct 2019, 10:06 AM
  • 25 Oct 2019, 10:04 AM
  • 13 Sep 2019, 02:32 PM
  • 27 Aug 2019, 08:46 AM
  • 27 Aug 2019, 08:45 AM

Checklist

hide

TestRail: Results

Activity

Show:

Cate Boerema January 7, 2020 at 4:21 PM

Oh that's great! Thank you so much

Zak Burke January 7, 2020 at 3:46 PM

Luckily it was an isolated change so a patch release was no problem, . Published in v1.14.2.

Cate Boerema January 7, 2020 at 1:21 PM

Fixed in snapshot. I don't know how it took me so long to get this tested! It was fixed ages ago.

Sadly, the fix isn't on BugFest. I don't suppose we could easily get a bugfix release for Q4 for this one ?

Matt Reno December 9, 2019 at 5:06 PM

After looking at the logs, it appears the UI is calling the PUT /circulation/requests API twice. I didn't see anything obvious in the UI code, but JavaScript is not my forte. I tried doing what I do to all UIs during testing and slammed the "Confirm" button a bunch of times and was able to send many requests to the backend. The first request succeeds and the next n -1 requests cause the popup described in this bug report. I think we should go with the simplest explanation here (double click on the button) and attempt to prevent that before proceeding with more backend analysis.

Ian Hardy October 25, 2019 at 2:48 PM

Here are logs from mod-circ, circ-storage and okapi where there are matches for that record ID. Let me know if there's anything else I can provide from folio-snapshot.

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Prokopovych

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created August 27, 2019 at 8:47 AM
Updated January 27, 2020 at 11:24 AM
Resolved January 7, 2020 at 1:21 PM
TestRail: Cases
TestRail: Runs