Cannot update request (possibly due to Javascript error)
Description
Steps to reproduce (taken from [CIRC-342])]:
Checkout an item
Create a request for that item
Click the edit button
Change any value
Click update request
Expected: Request is updated
Actual: Nothing happens
Technical Notes
I fixed what I believed to be the cause of requests not being updated in the backend. However, whilst manually testing that fix, I discovered that the UI is presently not making a request to the API.
Attached is the javascript error log (only the portion directly related to the save).
I think I'll close this since I filed separate bugs for these other issues: ,
Michal KuklisJune 17, 2019 at 3:49 PM
sounds good. I think if we can reproduce it it should be probably reported under a different story. I'm going to mark this as "in review". I hope that makes sense .
Marc JohnsonJune 17, 2019 at 2:40 PM
Edited
The error is definitely produced by the server side. And there have been server side bugs which result in that error. Whether than means it is a server side issue is hard to tell.
The position is provided by the client for a regular update, so it could be that the client got mixed up ( mentioned something in passing in the screen cast which made me wonder) or this could be a stale record and the lack of optimistic concurrency.
Without being able to recreate it, I think it will be hard to diagnose further.
Michal KuklisJune 17, 2019 at 2:35 PM
and I also tried to reproduce it here locally but everything works fine. Very strange. This does look like a server side issue though. Do you agree ?
Marc JohnsonJune 17, 2019 at 2:21 PM
Edited
I've just been in to folio-testing and attempted to update the request for ABA Journal (that I believe you used in the screencast). It updated successfully.
I also went through the whole flow described on folio-snapshot, and that updated successfully too.
I might need more help recreating the issue.
By any chance was the request already open in the UI when you went to follow up and edit it?
Steps to reproduce (taken from [CIRC-342])]:
Checkout an item
Create a request for that item
Click the edit button
Change any value
Click update request
Expected: Request is updated
Actual: Nothing happens
Technical Notes
I fixed what I believed to be the cause of requests not being updated in the backend. However, whilst manually testing that fix, I discovered that the UI is presently not making a request to the API.
Attached is the javascript error log (only the portion directly related to the save).