When a custom field used in a list is modified (Settings > Users > Custom fields), it breaks much of the functionality for that list.

Steps to reproduce:

1. Create a single checkbox custom field in Settings > Users > Custom fields

2. Go to the users app and select that custom field for one or more users

3. Create a list where the query includes the single checkbox custom field created in step #1

4. Make sure the single custom field is a visible column and save the list - everything should work as expected through this point

5. Go to Settings > Users > Custom fields and modify the the single checkbox custom field created in step #1

6. Confirm changes and save the custom field

7. Go back to the list created in step #3

8. Without making any edits, the lists still loads, and the custom field column header still displays

9. Click ‘Edit query’

Actual results:

• An error occurs when the query builder is opened and the app freezes
  
  Edit query

  • If the user edits the query then

    • Query box:

      • Display a warning toast. Message to display is - {fieldName} in your query is unavailable. Please revise your query.

    • Run & Save query button is disabled until the user removes all deleted fields.

    • Test query button is disabled until the user removes all deleted fields

    • Show columns should not display any deleted fields

  • Once user removes all deleted fields from the query then they should be able to test and save the revised query and list.

  • And the actions that previously generated an error toast notification should now work as expected on Edit/View List detail records.

  • Show column should not display any deleted field as an option

Expected outcome:

• The query builder loads with the query prepopulated

  • If a field cannot be prepopulated (it was deleted), it’s removed from the query

• The query can be edited

• If the user removes any query conditions referring to the missing custom field, the query can be tested / saved

• If the user tests the query without removing conditions referring to the missing custom field, an error message is displayed

• The app doesn’t freeze if the user clicks the ‘cancel’ button to close the query builder

Proposed dev approach from Zak Burke … it does not handle the situation where fieldOptions does not contain a matching fieldItem. Since it is permissible to remove custom fields, it feels like this is a straight up bug in the UI. Line 2 and everything after should be fenced off by a conditional like if (!!fieldItem) { ... } .

Current outcome when ‘Edit query’ is clicked