I've put the issue in review, since, though I've done my best to validly test it locally, the bug originally only showed up in testing/snapshot, so guess that's where the fix ultimately has to be verified.
Niels Erik Nielsen May 15, 2019 at 2:46 PM
I've fixed it in ui-tenant-settings and asked on Github for his opinion on the approach.
Cate Boerema May 15, 2019 at 8:18 AM
I would think we'd only need to fix in ui-tenant-settings as Settings > Organization is going away (soon I hope!) Looking forward to an update on the progress with that.
Marc Johnson May 15, 2019 at 8:12 AM
yes, the issue should be fixed only in UI tenant settings (at least for the moment, depending upon which we chose to include in Q2.1 and whether this needs fixing there too).
It might be worth checking with about where we are with the transition to tenant settings.
Steps to repro:
Log into folio-snapshot
Go to Settings > Organization > Service Points and pick an SP
Edit SP
Modify the print by default settings so Hold is unchecked and Transit is checked
Save
Expected: Hold says "no" and transit says "yes"
Actual: Hold says "yes" and transit says "no"