Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Add Hold Shelf Expiry Period to Service Point

Description

Purpose: To add a hold shelf expiration period to the service points where pickup location/service point = yes. This will be used as the default expiration period for items on the hold shelf at the service point. Hold shelf expiration date can be manually overriden in the request record, as well.

User story:
As a librarian who has checked in an item needed for a request at my service point
I want the hold shelf expiration date to be set for that request based on the default expiration period for the service point
So I know when the hold has spent enough time on the hold shelf without being picked up and I can re-shelve it

Scenarios:

  1. Scenario Check Mark

    • Given the Service point record (create, edit, view) in Settings > Organization > Service Points

    • When "Pickup location" = Yes

    • Then a new set of fields should display: Check Mark

      • Label: Hold shelf expiration period

      • Field 1:

        • Type: Short field - There is a control in the Loan policy form for a similar field that disallows anything but integers so, if we use that, we don't need to have a validation error defined Check Mark

      • Field 2:

        • Type: Dropdown Check Mark

          • Default = Select interval

          • Values = Minutes, Hours, Days, Weeks, Months

      • Fields should look and behave like the similar fields in the loan policy form

  2. Scenario Check Mark

    • Given the Service point record (create, edit, view) in Settings > Organization > Service Points

    • When "Pickup location" = No

    • Then these new fields should not display

Acceptance Criteria:

  • Unit tests and big test coverage

Mockup: https://drive.google.com/file/d/1WHqQ_3UDs9CkXibUCVLD7lIcwh22wyAM/view?usp=sharing

Environment

None

Potential Workaround

None

Attachments

1

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie Breaux February 12, 2019 at 9:36 PM
Edited

tested on folio-snapshot. There's a little hiccup with the integer field and using the up caret to increase the digits, but it worked. It's a little weird to reproduce, and you can get the caret to work and you can type a number, so that seems good enough to me. Closing this ticket.

Aditya matukumalli February 4, 2019 at 10:09 AM
Edited

I may have missed any recent conversation or questions concerning this story as I am away on vacation currently. But as far as I know, the PR related to this story on the UI should be ready to merge once the backend PR is merged in. or Please let me know if any further UI changes need to be made for this story. Also, if this requires a change in the requests app to show a validation error, I think its better to work on it as a separate JIRA bug, and get this merged in first. Please correct me if I am missing something elementary here.

Cate Boerema February 4, 2019 at 8:32 AM

, and Wow - not sure why I am only seeing these questions now. Is this open question why this feature is blocked?

We need to wrap the first version of this feature up ASAP. What is easiest at this point? If we allow a service point to NOT have an expiration period, then we need to make it possible for a request to not have an expiration period. Right now, it seems the back end is preventing that:

If we REQUIRE a service point to have an expiration period, then we can leave Requests as-is (where an expiration date is required). That said, we'll need to adjust the UI so we get a user friendly validation error instead of the one from the backend.

Again, let's do what is easiest right now. We can come back and adjust later, if needed.

Aditya matukumalli January 17, 2019 at 2:01 PM
Edited

Yes, currently that is how the UI is developed ( If yes is selected for the pickupServicePoint, the form gets blocked from submitted if no value is entered ). Correct me if this is wrong

Marc Johnson January 17, 2019 at 12:41 PM
Edited

For scenario 1, is the hold shelf expiry period required when a service point can be used for pickup? And if so, it should not be possible to save a service point without selecting one?

(I think we discussed the opposite in the grooming session, that a expiry period should not be allowed when the service point cannot be used for pickup).

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Prokopovych

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created December 3, 2018 at 4:22 PM
Updated February 25, 2019 at 8:07 PM
Resolved February 12, 2019 at 9:36 PM
TestRail: Cases
TestRail: Runs

Flag notifications