Instance 3rd pane Actions menu: Adjust Edit action

CSP Request Details

None

CSP Rejection Details

None

CSP Approved

None

Description

Purpose: In a consortium environment, Instance records may be shared amongst the member institutions or restricted to a single member tenant. When editing Instances, FOLIO needs to distinguish whether an instance being edited is Local or Shared, since those options 1) require different user permissions and 2) the edited Instances are stored in different Inventory-storage modules and 3) shared Instances require updates to their shadow instances in member library tenants

As a staff person editing Inventory instances
I want to be able to distinguish between editing local and shared instances
So that shared instances can have tighter permissions, and so that FOLIO distinguishes the different data flows and storage for local/shared instances

Scenarios

  1. Scenario 1 [no change] Check Mark

    • Given the Action menu in the Inventory second pane

    • When the tenant is a non-consortial tenant

    • And a user has permission to edit Instances (UI permission: Inventory: View, create, edit instances)

    • Then display the edit action and permit the user to edit instances

  2. Scenario 2 Check Mark

    • Given the Action menu option "Edit instance" in the Instance detail (third) pane

    • When the tenant is a Member library tenant

    • And the instance is local

    • And a user has permission to edit Instances (UI permission for Member library tenant: Inventory: View, create, edit instances)

    • Then display the edit action and permit the user to edit it

    • But do not permit the user to edit shared instances

  3. Scenario 3 Check Mark

    • Given the Action menu option "Edit instance" in the Instance detail (third) pane

    • When the tenant is a Member library tenant

    • And the instance is shared

    • And a user has permission to edit shared Instances (UI permission for Central consortial tenant: Inventory: View, create, edit instances)

    • Then display the edit action and permit the user to edit it

  4. Scenario 4 Check Mark

    • Given the Action menu option "Edit instance" in the Instance detail (third) pane

    • When the tenant is a Member library tenant

    • And a user is editing a shared instance

    • And the user saves their edits

    • Then change the text of the standard green success toast to read:

      • This shared instance has been saved centrally, and updates to associated member library records are in process. Changes in this copy of the instance may not appear immediately.

    • NOTE: Once the member library's shadow instance is updated (based on the changes to the central shared instance), if a member library user is still displaying the instance details on their screen, those updates should appear automatically, without the user having to manually refresh the screen.

  5. Scenario 5 Check Mark

    • Given the Action menu option "Edit instance" in the Instance detail (third) pane

    • When the tenant is a Central consortial tenant

    • And the instance is shared (which all instances in the Central tenant will be)

    • And a user has permission to edit shared Instances (UI permission for Central consortial tenant: Inventory: View, create, edit instances)

    • Then display the edit action and permit the user to edit it

  6. Scenario 6 Check Mark

    • Given the menu option "Edit instance" for a member library or non-consortial tenant

    • And a user selects that menu option, edits the instance, and saves it

    • And the instance is local

    • Then update the instance as usual

    • And save it in the local tenant's inventory-storage

  7. Scenario 7 Check Mark

    • Given the menu option "Edit instance" for a member library or central consortial tenant

    • And a user selects that menu option, edits the instance, and saves it

    • And the instance is shared

    • Then update the shared instance

    • And save it in the Central consortial tenant's inventory-storage

    • And update any related shadow instances in the member library tenants

    • NOTE: See updated success toast wording for the shadow instances in scenario 4 above. Do not change the wording for the success toast in the central consortial tenant.

  8. Scenario 8

    • Ensure automated testing coverage for this new code is 80% plus

Testing

  1. Edit instance in non-consortial tenant

  2. Edit local instance in member tenant

  3. Edit shared instance in member tenant, and confirm success toast wording

  4. Edit shared instance in central consortial tenant

  5. And if no permission to edit, make sure the edit option does not appear

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie Breaux September 25, 2023 at 10:38 AM

Hi All looks good with this story - thank you for making the changes! One small bug that I'll add separately - when local instances are updated in the member tenant or non-consortial tenant, they no longer have the HRID number in the success toast. We don't include the HRID in the success toast for the shared instance edits. If it would be easier to include the HRID in both the local and shared instance edit success toasts, please let me know.

Also, , , in scenarios 4 & 5, when a user is editing a shared instance, we changed the toast to make it clear that the updates may now show immediately across the shared and shadow instances. Now that we're showing the shared instance in both central and member tenants, do you think we should adjust the messaging to just use the regular editing success toast? In some ways, I like the new success toast that provides a low-key reminder that the edits are (may be) happening in multiple places.

And Thank you for all the tests!

Maksym Ishchenko September 18, 2023 at 5:06 PM

Hello  

Ticket verified on Folijet rancher. All works as expected. Moving ticket to In review column

Screencasts you can find in related FAT's

Ann-Marie Breaux June 27, 2023 at 4:35 AM

Removed scenario for editing local instances in Consortial tenant, and moved that to possible Phase 2 work. Also simplified the permissions, based on convo with Dennis. And simplified the test scenarios. 

Ann-Marie Breaux June 27, 2023 at 4:34 AM

Hi   Yes, that was a mistake

Mariia Aloshyna June 12, 2023 at 10:25 AM

Hi Scenario 6 says that a non-consortial tenant edits a shared instance, is this a mistake and the instance is local?

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Folijet

Fix versions

Release

Poppy (R2 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created May 31, 2023 at 7:55 AM
Updated November 22, 2023 at 1:49 PM
Resolved September 25, 2023 at 10:39 AM
TestRail: Cases
TestRail: Runs

Flag notifications