Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Succeeding titles. Make the Title element required. Instance (edit view)

Description

Overview: Carry over work from the implementation of Preceding and Succeeding titles.

  1. Login to FOLIO Snapshot, go to Inventory

  2. Search for ABA Journal

  3. When viewing the instance record in edit mode, and drill down to the Title accordion

  4. Given I have clicked the "Add succeeding title" button, and the row of elements displays

Expected result:
Then when filling in the data, it should not be possible to save the changes, if the Title element is not entered, or the Title is not being connected with an existing record in Inventory.
If trying to save and update without the Title data being entered/populated, then following error message in red will display below the Succeeding titles Title element: Please fill this in to continue

Actual result:
The Succeeding titles Title element is marked as required, but it's possible to save the changes without having added the required title data, and you get no error messages

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

4
  • 15 Apr 2020, 07:21 AM
  • 31 Mar 2020, 02:05 PM
  • 17 Mar 2020, 08:11 AM
  • 17 Mar 2020, 08:10 AM

Checklist

hide

TestRail: Results

Activity

Show:

Charlotte Whitt April 15, 2020 at 7:21 AM

Manual test in FOLIO Snapshot, version @folio/inventory 2.0.1000855, using Chrome.

Looking great. Thanks slightly smiling face I'll close the ticket.

Charlotte Whitt March 31, 2020 at 2:05 PM

On the MM-SIG channel following survey was done:

And it is:
7 Yes - we want the title for preceding/succeeding to be required
0 No - we do not want the title for preceding/succeeding to be required

Here a couple of comments:

  • I would say in each case make the title element required

  • I voted with 'yes'. Reason: Having at least a title when modelling predecessor-successor relationships seems reasonable. @charlotte In case we link serials, there should be a title present in 100 % of the cases.

  • i vote yes to both please--let’s make the titles required

  • I vote yes to both as someone who uses this info all the time

Cate Boerema March 31, 2020 at 8:10 AM

Just putting this in Draft for now, as is going to double check with the MM SIG whether this needs to be required.

Charlotte Whitt March 20, 2020 at 6:03 PM

Hi - yes, agreed.
Will you or should I write up a MODINV-XXX and a MODINVSTOR-XYZ for the conditional validation for unconnected preceding or succeeding titles.
If we don't need MODINCSTOR-XYZ - we can deprecate it later.

Marc Johnson March 20, 2020 at 4:53 PM
Edited

We should stick to the general guidance that the ui and back end api should be consistent. I don't think it's required in the API currently because you can save the record without a title (when adding an unconnected title)

The system should definitely prevent you from being able to doing a manual enter of a Succeeding title, without a title! That's a bug.

I want to check if I have my understanding of this correct.

We want title to be required for any unconnected preceding or succeeding title.

Given that, and the need for the API to be consistent with the UI, we need a backend story in mod-inventory (at least, maybe in storage too) to introduce conditional validation for unconnected preceding or succeeding titles so that they must have a title?

Is that a reasonable summary?

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Story Points

Sprint

Development Team

Prokopovych

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created March 17, 2020 at 8:02 AM
Updated September 15, 2020 at 9:04 AM
Resolved April 15, 2020 at 7:22 AM
TestRail: Cases
TestRail: Runs

Flag notifications