Provide "required" field for subfields in field mapping

CSP Rejection Details

None

CSP Request Details

None

CSP Approved

None

Description

Review these 3 issues together at refinement: UIDATIMP-1516, UIDATIMP-1384, MODINV-809

  • To avoid hardcoding uri as required in di-core use the BE "required" flag in mapping rule for uri

  • Prevent creating empty notes

Steps:

  • provide property "required" with value "true" for the following subfields and red asterisk next to the fields below marked with an asterisk, in the field mapping create and edit screens - , we are moving the red parts out of scope from this ticket, we only need changes for BE

  • NOTE Cannot make them required, since may not be required on a create or edit screens - what to do? Use info icon?

 Holdings mapping profile:

  1. Holdings notes (Note type*, Note*,Staff only) (but only when a Holdings note is specified in the Holdings field mapping profile)

  2. Electronic access (Relationship*, URI*, Link text, Materials specified, URL public note)  (but only when Electronic access is specified in the Holdings field mapping profile)

 Item mapping profile:

  1. Item notes (Note type*, Note*,Staff only) (but only when an Item note is specified in the Item field mapping profile)

  2. Check in / Check out (Note type*, Note*,Staff only) (but only when a Check in / Check out note is specified in the Item field mapping profile)

  3. Electronic access (Relationship*, URI*, Link text, Materials specified, URL public note) (but only when Electronic access is specified in the Holdings field mapping profile)

Example:

Environment

None

Potential Workaround

None

Attachments

2

Checklist

hide

TestRail: Results

Activity

Show:

Ann-Marie BreauxSeptember 25, 2023 at 1:41 PM
Edited

Hi Changes look good - thank you!

I attached a MARC file and a video showing profiles and testing for this Jira. Please create a TestRail when you get a chance. It tests item notes, holdings notes, and electronic access in holdings and items, but does not check circulation notes in items. Please let me know if you want to look at it together. The job profile and import are on Folijet Rancher if you want to take a look at it. Thank you!

Ann-Marie BreauxSeptember 6, 2023 at 2:01 PM

Let me know if you want to talk through the tests for this

Ann-Marie BreauxSeptember 6, 2023 at 2:00 PM

Folijet refinement: only changed the "required" property for the BE; not making it required or adding info icon on the UI. But - when UI sends data to the BE during import, if there is no data for the "required" fields, then BE will not build the compound data element. e.g. if there is a holdings note with a defaulted note type and staff only, and mapped text from 945$i, BUT, there is no 945$i in the incoming MARC Bib, then - after this change - the BE will not create a holdings note with a type and staff only, but blank text.

Kateryna SenchenkoSeptember 6, 2023 at 9:10 AM

Hi , in scope of this task please test MODINV-809 and MODINVSTOR-1093 with empty note 

Mariia AloshynaSeptember 5, 2023 at 2:33 PM

Hi and changes have been already deployed to snapshot-2, could someone test it, please?

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Folijet

Fix versions

Release

Poppy (R2 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 23, 2023 at 8:46 AM
Updated January 23, 2024 at 9:57 AM
Resolved September 25, 2023 at 1:39 PM
TestRail: Cases
TestRail: Runs