Review these 3 issues together at refinement: UIDATIMP-1516, UIDATIMP-1384, MODINV-809

Overview: When either updating a holdings record or creating a new one via Data Import, if the incoming MARC record does not contain a field being used to map a Holdings note then it creates an empty one.  Considering that the UI does not allow any Holdings note to be created where the 'Note' field is blank, I'm labeling this a bug.  

Steps to Reproduce (Updates):

1. Log into bugfest-orchid

2. Need a job profile that updates a holdings record by adding a Holdings note

   1. Can use the job profile I created for testing = Corrie test: updates holdings record with notes.

   2. Create a new one:

      1. Field mapping profile maps a MARC field (such as a 990$d) in the incoming record to a Holdings note (either 'electronic bookplate' or 'action note') in the Holdings record

      2. Action profile Updates a holding record using the newly create field mapping profile

      3. Match profile that uses the 999 to match on either Holdings HRID or UUID

      4. Job profile that matches on the incoming 999 and implements the associated action profile that adds a Holdings note

3. Create a .mrc file of the MARC bibliographic record for the record which is meant to be updated.  DO NOT include the field used in the Field mapping profile for the Holdings note.  If the mapping profile used a 990$d, do not include the 990$d in the record (i.e. leave the subfield absent, not just blank).

4. Open Data Import and upload the file and apply the appropriate Job Profile.

Steps to Reproduce (Creates):

1. Login to bugfest-orchid

2. Similarly, I created job profiles that create a holdings record matching on the 999$i in the MARC bib of the incoming record: Corrie test: create holdings record with notes.  

   1. A new profile can also be created where the match is the Instance UUID or HRID, the action creates a new holdings record, and the field mapping profile maps the 990$d (for example) to a note in the Holdings record.

3. Open Data Import and upload a test file of a MARC bibliographic record (with NO 990$d) of an existing Instance/SRS in FOLIO.  Process using the appropriate Job Profile.

Expected Results: In both scenarios, there should be no note in the Holdings record because there is no data to map.
Actual Results: A Holdings note has been added to the record with a blank 'Note' field.

Additional information: I tested both the 'Electronic bookplate', 'Action note', and 'Note' Note Type under Holdings notes.  All 3 fields behaved the same in both folio-snapshot.dev and bugfest-orchid so I expect any Note Type behaves similarly.

Folijet: See attached videos. I tested all the free-text fields on the holdings and item records in Snapshot, by trying to create a new holdings and item, and mapping from 990 subfields for the holdings and from 991 subfields for the item. I had an error when creating the holdings.

The expected outcome should be:

1. For free text field (repeatable or non-repeatable): If MARC field/subfield does not exist, then do not create/populate that field in the holdings or item record

2. For free text field associated with a non-free text field (e.g. free-text note associated with a Note type, or URL associated with an Electronic access type, or with a Staff only checkbox), then do not populate any of the associated fields if there is no mapped data in the incoming record. This would apply to 

   1. Holdings:

      1. Holdings notes (Note type, Note, Staff only)

      2. Electronic access (Relationship, URI, Link text, Materials specified, URL public note)

      3. Receiving history (Public display, Enumeration, Chronology)

   2. Item

      1. Item notes (Note type, Note, Staff only)

      2. Check in / Check out (Note type, Note, Staff only)

      3. Electronic access (Relationship, URI, Link text, Materials specified, URL public note)

Error message when using the profile outlined in the attached video: 

See attached screenshot: UIDATIMP-1452 Create error message.png