[BE?] Fee amount tokens not showing 2nd decimal in automated notices, if 2nd decimal = 0

Description

Overview:

In automated fee/fine notices, IF 2nd decimal  = 0 (e.g. 25.9*0*), THEN it gets droped in the amount tokens (i.e. shows as: 25.9).
This does NOT happen if 2nd decimal ≠ 0 (e.g. 25.9*9*); in this case, the 2nd decimal is shown (i.e. 25.99). 

Affected notice categories:
_ Automated fee/fine charge
_ Automated fee/fine action (refund or cancel)

These categories are NOT affected (even though they use the same tokens):
_ Manual fee/fine charge
_ Manual fee/fine action (pay, waive, refund, transfer or cancel/error)

Affected tokens: 
_ feeCharge.amount
_ feeCharge.remainingAmount

Steps to Reproduce:

  1. Log into Lotus

  2. To get an automated notice with all amount tokens, send yourself a notice with trigger event = Lost item returned - fee(s) adjusted (see here: https://folio-org.atlassian.net/wiki/display/FOLIOtips/C%29+How+to+generate+a+loan...+that+ages+to+lost)
    NB: But any automated fee/fine notice works.

Expected Results:

If amount in Lost item fee policy = 25.90, then the amount shown = 25.90.

Actual Results:

The amount shown = 25.9 .

Additional Information:
_ P4, because: Technically, the information is not wrong. It's rather that: Because the 2nd decimal is shown in the manual fee/fine notices, even if it's 0, the tester then assumed that the missing 2nd decimal meant that there was something wrong with showing the token content. This just causes unnecessary questioning. 

_ I could replicate in Snapshot. Cannot check in https://folio-kiwi.dev.folio.org/ because emails are turned off.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

Know that the missing 2nd decimal missing does not mean that the information is not shown; it means that the 2nd decimal is a 0, and therefore ultimately, 25.90 = 25.9.

Attachments

2

Checklist

hide

TestRail: Results

Activity

Show:

julie.bickle August 2, 2022 at 11:43 AM
Edited

I confirm that this is fixed in MG bugfest.
I now realise that I forgot to add the fields "feeAction.amount" and "feeAction.remainingAmount" in the ticket description [massive face palm], so I will clone this ticket so that they also get addressed.

Alexander Kurash August 1, 2022 at 11:07 AM

Yes, it was released in MG, but for some reason MG version of mod-circulation wasn't deployed until recently. Could you please retest this?

julie.bickle July 20, 2022 at 9:04 AM
Edited

This works in Snaphost, but still not in MG bugfest:

feeCharge.amount = 3.0
feeCharge.remainingAmount = 3.0

Is that considered in Release = Morning Glory R2 2022 ?

Dmitriy Litvinenko July 19, 2022 at 8:24 AM

Hello Could you please confirm that i understand correctly that BE fixed this bug in "Morning Glory R2 2022"?

CC:  

julie.bickle July 15, 2022 at 3:51 PM

I closed this, but actually I'm not sure that was correct, as it's tagged for MG bug fix.

Done

Details

Assignee

Reporter

Priority

Development Team

Vega

Release

Morning Glory (R2 2022)

RCA Group

Not a bug

Affected Institution

MI State University/Library of Michigan

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created March 23, 2022 at 11:50 AM
Updated October 24, 2023 at 11:58 AM
Resolved July 15, 2022 at 3:51 PM
TestRail: Cases
TestRail: Runs