Unable to delete fixed due date schedule with permission ui-circulation.settings.fixed-due-date-schedules

Description

The permission Settings (Circ): Can create, edit and remove fixed due date schedules does not allow someone to remove fixed due date schedules unless that person also has permissions to edit circulation rules.

Found on bugfest. 

If you have a user who just has the permission ui-circulation.settings.fixed-due-date-schedules they are able to create due date schedules, and edit due date schedules, but they don't get the delete button:

It appears from https://github.com/folio-org/ui-circulation/blob/master/src/settings/FixedDueDateSchedule/FixedDueDateScheduleForm.js#L175 that a FOLIO user must have permission ui-circulation.settings.circulation-rules in order to be able to delete a fixed due date schedule.

I verified this by adding ui-circulation.settings.circulation-rules to my single permissioned user, and they were then able to see the delete button.

I suspect the permission in the fixed due date schedule form is incorrect, and so fixing this would be pretty straightforward. 

User story:

The functions of managing fixed due date schedules and managing circulation rules can be assigned to different staff.

As a user with permission to create and edit fixed due date schedules, I also need permission to delete fixed due date schedules without also having permission to create, edit and delete circulation rules.

Scenario:

As a user with the permission Settings (Circ): Can create, edit and remove fixed due date schedules and without the permission Settings (Circ): Can create, edit and remove circulation rules

When I choose edit Fixed due date schedules in Settings

Expected result:

Delete button is displayed and active at the bottom of the edit screen

Actual result:

Delete button is not displayed

 

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

2
  • 26 May 2022, 06:18 AM
  • 25 Oct 2021, 03:33 PM

Checklist

hide

TestRail: Results

Activity

Show:

(OLD ACCOUNT) Erin Nettifee May 26, 2022 at 12:43 PM

Tested on snapshot 5-26-2022, works as expected. Thanks !

Stanislau Snapok May 26, 2022 at 6:19 AM

Hello .
Tested on the snapshot, works as expected.
Evidence added.

cc:

Cheryl Malmborg April 28, 2022 at 7:37 PM

I have edited the description and added a short user story.  It will be alright to keep the permission Settings (Circ): Can create, edit and remove fixed due date schedules as a single permission.  The remove permission does need to be modified so that it is not dependent on also having circulation rule permissions.

Stephanie Buck April 25, 2022 at 1:02 PM

Thanks, . Please see 's comment above, and please note that there are 2.5 sprints left for Morning Glory development. If this is to be included, we'll need the new story soon.

Stanislau Snapok April 25, 2022 at 7:18 AM

 does it mean that this bug can be closed as "Won't do"?
Thanks!

cc:

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Vega

Fix versions

Release

Morning Glory (R2 2022)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 25, 2021 at 3:33 PM
Updated June 2, 2022 at 2:36 PM
Resolved May 26, 2022 at 12:44 PM
TestRail: Cases
TestRail: Runs

Flag notifications