Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Circulation rules editor - Refactor circulation-rules-test.js and circulation-rules.js

Description

Description:
Many tests were added during the development of the circulation rules editor to keep the test coverage on the needed level. But now there are a lot of code lines (more than 1000) in several files that should be structured more efficiently to make future maintenance easier.

Acceptance criteria:

  • The coverage numbers shouldn't be less after refactoring (Please, provide images of coverage report before and after changes)

  • circulation-rules.js and circulation-rules-test.js should be split into several files to structure tests and interactors

  • The changes should be reviewed by several developers (at least 3)

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Yevhenii MaltsevNovember 28, 2019 at 1:57 PM

Screenshots are provided in PR description: https://github.com/folio-org/ui-circulation/pull/485

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Concorde

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 31, 2019 at 12:35 PM
Updated January 15, 2020 at 1:42 PM
Resolved November 28, 2019 at 1:59 PM
TestRail: Cases
TestRail: Runs

Flag notifications