Store (and dereference) UUID in loan rules instead of literal values
Description
In the course of we have decided to delay until after alpha. This means that the values in the loan rules accepted in the /apply endpoint should use UUIDs rather than literal values (for things like patron groups, material types, etc). As such the loan rule editor should be altered to store UUIDs for rule properties selected from the drop-downs and dereference UUIDs from loan rules loaded from the server.
If the loan-rules editor still works, then this issue is fixed.
Anya February 27, 2018 at 8:43 PM
Is this a test for ICs to do or someone else ? If ICs we need a test scenario... if for someone else does it belong in this list?
Michal Kuklis January 16, 2018 at 3:58 PM
Edited
Ok just added https://folio-org.atlassian.net/browse/UIIT-84. I also just noticed that I don't get the unsaved changes modal from loan rules editor anymore so I will keep this one in progress as well and review it again...
Michal Kuklis January 16, 2018 at 3:55 PM
Thanks ! It doesn't look like the bug belongs to this story. I will create a new bug for this.
Cate Boerema January 16, 2018 at 3:48 PM
Sorry - should have been more clear. Steps:
Log into folio-testing
Go to Settings > Items > Loan Types
Add a new loan type
Hit save to save new loan type
Appears to have saved
Attempt to navigate away
Expected: Can navigate away without an unsaved changes modal. My new loan type should have already been saved.
Actual: Get unsaved changes modal when navigating away. If I click Discard, the new loan type is no longer there when I navigate back to the Loan types page.
In the course of we have decided to delay until after alpha. This means that the values in the loan rules accepted in the /apply endpoint should use UUIDs rather than literal values (for things like patron groups, material types, etc). As such the loan rule editor should be altered to store UUIDs for rule properties selected from the drop-downs and dereference UUIDs from loan rules loaded from the server.