SPIKE: investigate upgrading loan rules editor

Description

IIRC the loan rules editor library is out of date and may need to be upgraded to maintain compatibility with current versions of React.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Zak Burke January 14, 2019 at 1:09 PM

Current status: We're on react-codemirror2 ^1.0.0. There are some react v16.0 compatibility warnings during the build with 1.0.0 but in the browser everything runs OK.

The current react-codemirror2 release is 5.1.0. Upgrading appears to be a straightforward process with some minor changes to how things are imported. The platform-core#snapshot test loan_renewal passes successfully. Testing manually, I had saw some issues with focus and cursor placement, e.g. clicking an item on a menu works but using the arrow keys moves the cursor within the editor although it appears to change the selection on the menu.

Summarizing, upgrading to a current release resolves the build compatibility warnings we currently see and editing appears to work correctly, although it is more finicky than in previous releases. There do no appear to be any changes to how the JSON data is interpreted or rendered. We should still plan the upgrade as we are years out of date, but this work need not be a prerequisite to changes in how we use the editor, e.g. . It may be pursued later or in parallel.

Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Prokopovych

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created January 11, 2019 at 1:34 PM
Updated September 24, 2019 at 1:58 PM
Resolved January 14, 2019 at 7:47 PM
TestRail: Cases
TestRail: Runs