Check out - Do not trim barcode before it is sent to backend for processing
Description
CSP Request Details
CSP Rejection Details
Potential Workaround
Attachments
defines
relates to
Checklist
hideActivity
Oleksandr HrushaSeptember 30, 2024 at 6:49 AM
Checked on sprint testing env, works as expected
Oleksandr HrushaSeptember 23, 2024 at 7:13 AM
Checked on snapshot, works as expected
Wating for sprint testing
Thomas TruttMay 30, 2024 at 2:47 PM
, and – I tested on our Poppy CSP-5 env and now better understand what is happening.. My org thought was that the item was being retrieved after check-out by barcode, but that is not the case.. Item is being called by barcode and BEFORE check-out by barcode. this error is also extended to the prices dialog as well since all these dialogs are dependant on the results of /inventory/items .
The org specs for check-in / out as I understand them were not supposed to trim white space, that is the issue here. Check-out by barcode is trimming white space but /inventory/items is not. So when an item is checked out an empty item set is returned hence the notes are not displayed.
This could be handled in one of two ways ---
front end - Check the number of items returned when
/inventory/itemsis called: (switchtotalRecords)0: throw error message (Barcode not found) do not call
circulation/check-out-by-barcode1: display notes - call
circulation/check-out-by-barcode>1: display item selection - display notes – call
circulation/check-out-by-barcode
In all scenarios /inventory/items is referenced before circulation/check-out-by-barcode is called.
back end - Modify
circulation/check-out-by-barcodeto fail when an exact barcode is not found in the inventory.
My suggestion is to do both.
Tara BarnettMay 28, 2024 at 8:25 PM
Hello ! Spokane does NOT have “Perform wildcard lookup of items by barcode in circulation apps (Check in, Check out)” checked. They are not performing wildcard lookups.
However, I think the scenario discusses above is actually inverse of the issue here: the barcode in Inventory does NOT have a space (example: “10101”). The space is being accidentally added in the check out or check in app (example: “10101 “). Because the record in inventory does NOT have a space, the wildcard search in check out and check in does not find the record at all, because it is not trimming the whitespace.
Stephanie BuckMay 28, 2024 at 7:39 PM
Thank you, . , can you review the setting for Spokane “Settings → Circulation → Other settings → Perform wildcard lookup of items by barcode in circulation apps (Check in, Check out)”?
Details
Assignee
Artem BlazhkoArtem BlazhkoReporter
Tara BarnettTara BarnettLabels
Priority
P3Story Points
0.5Sprint
NoneDevelopment Team
VegaFix versions
Release
Ramsons (R2 2024)RCA Group
Requirements changeAffected releases
Quesnelia (R1 2024)Poppy (R2 2023)TestRail: Cases
Open TestRail: CasesTestRail: Runs
Open TestRail: Runs
Details
Details
Assignee
Artem BlazhkoReporter
Tara BarnettLabels
Priority
P3
Purposed solution:
Ensure that he UI passes the exact barcode that is entered into the barcode box (check in / out) is passed to all backend calls. The trim function should not be performed.
Issue:
In the check out app and the check in app, whitespace is trimmed when it appears at the beginning or end of a barcode. (For example, “10101” and “10101 “ and “ 10101” all bring up the same item.) This means that a user can enter a barcode that begins or ends with whitespace and the item will still check out correctly.
However, item notes seem to be tied into these apps with API requests that do not trim whitespace. Based on chrome developer tools, it looks like the affected request is:
When an item has a check in or check out note and the user accidentally includes a space in the barcode, the check in and check out notes do not appear.
Current workaround:
Be careful to enter barcodes exactly as they are recorded on the item record.
Steps to Reproduce:
Log in to folio-snapshot as diku_admin
Find an item (such as barcode “10101”) and add a check out note and a check in note
Go to the check in app and enter the barcode of the item exactly as it is recorded on the item record (for example, “10101”)
Your pop up check in note will appear
Next, check in the item but include a space after the barcode (for example, “10101 “)
Your pop up check in note will NOT appear
The same is true of the check out app.
Expected Results:
Pop up notes should appear for all items that are successfully check in or out.
Actual Results:
Adding whitespace to the start or the end of the barcode results in the transaction going through WITHOUT the pop up note being displayed to the staff user.
Interested parties:
Spokane Public Library
Original title:
When checking in/out items, an added space will cause check in and check out notes to not pop up