Check in - Do not trim barcode before it is sent to backend for processing

Description

Purposed solution:

Ensure that he UI passes the exact barcode that is entered into the barcode box (check in / out) is passed to all backend calls. The trim function should not be performed.

Overview:

In the check out app and the check in app, whitespace is trimmed when it appears at the beginning or end of a barcode. (For example, “10101” and “10101 “ and “ 10101” all bring up the same item.) This means that a user can enter a barcode that begins or ends with whitespace and the item will still check out correctly.

Steps to Reproduce:

  1. Log in to folio-snapshot as diku_admin

  2. Find an item and add a check in note

  3. Check in the item but include a space after the barcode

Expected Results:

Pop up notes should appear for all items that are successfully check in

Actual Results:

Adding whitespace to the start or the end of the barcode results in the transaction going through WITHOUT the pop up note being displayed to the staff user.

Original Title:

When checking in items, an added space will cause check in notes to not pop up

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

2
  • 30 Sep 2024, 06:49 AM
  • 23 Sep 2024, 07:14 AM

Checklist

hide

Activity

Show:

Oleksandr Hrusha September 30, 2024 at 6:49 AM

Checked on sprint testing env, works as expected

2024-09-30_09h48_39.mp4

Oleksandr Hrusha September 23, 2024 at 7:14 AM

Checked on snapshot, works as expected

Wating for sprint testing

 

2024-09-23_10h13_55.mp4

Stephanie Buck May 28, 2024 at 7:40 PM

Thank you, . , can you review the setting for Spokane “Settings → Circulation → Other settings → Perform wildcard lookup of items by barcode in circulation apps (Check in, Check out)”?

Thomas Trutt May 28, 2024 at 4:48 PM

Ill also add a comment to: https://folio-org.atlassian.net/browse/UICHKOUT-903 . As of right now a barcode can have a leading or tailing space and it is considered valid. MM is discussing data cleanup and restrictions around the barcode field and others. Until that is completed the original spec allowed for a space to lead, trail or be within a barcode.
There is a setting in Settings → Circulation → Other settings → Perform wildcard lookup of items by barcode in circulation apps (Check in, Check out)
If this is checked and the above scenario is performed then it is a bug. If this is not checked the above is not a bug as it should be an exact match on the barcode. The same is true for Check-in and check-out. If unchecked the barcode entered needs to match the barcode in inventory. Only if it is checked then would other of versions of that barcode be retrieved. IE “123456” is entered but “123456 “ is retrieved.

In either case the notes should be retrieved that correspond to the item being checked out / in. One suggestion i would have to help remove some of the complexity around this is instead of using the barcode to search for notes is to use the item’s UUID if possible.

cc: , - Thoughts?

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Vega

Fix versions

Release

Ramsons (R2 2024)

RCA Group

Requirements change

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created April 23, 2024 at 9:14 AM
Updated December 9, 2024 at 1:30 PM
Resolved September 30, 2024 at 2:06 PM
TestRail: Cases
TestRail: Runs

Flag notifications