Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Basic search. Reset all button, should clear previous Search delimiter

Description

Purpose: The Reset button in Inventory does not properly reset the query-index dropdown menu (above the search field).

Steps to reproduce:

  1. Go to FOLIO Snapshot, the Inventory app

  2. Search on Identifier as delimiter, value: "AJMEAZ", and you get 1 result: The American Journal of Medicine

  3. Click the 'Reset all' button

Expected result:
All filter and defined Search delimiters are cleared.

Actual result:
The search delimiter Identifier persist

Background documentation:

Question to and - would this be easily solved by using the updated SearchandSortQuery component?

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

3

Checklist

hide

TestRail: Results

Activity

Show:

Charlotte Whitt July 16, 2019 at 2:13 PM

Manual test in FOLIO Snapshot, version @folio/inventory 1.11.1000533, using Chrome.

The steps are verified and I get the expected result 'All filter and defined Search delimiters are cleared', when I click the 'Reset all' button

I also did several misc. search request, using the different search delimiters, different combinations with filters, hitting Reset - over and over.
And the fix worked every time All looks good.

I'll close the bug as done.

Zak Burke July 8, 2019 at 2:17 PM

That's correct, ; same fix for ui-search and wherever there is a menu/filter/we-need-a-better-name-and-should-probably-provide-a-UI-label-for-this attached to the search box.

Niels Erik Nielsen July 8, 2019 at 1:24 PM

Instances.js needs to pass filterChangeCallback to <SearchAndSort>. Simply implementing this causes the filter checkboxes not to clear when the 'reset all' button is clicked so this requires a little bit of investigation, but is likely an easy fix in the end.

Guess this applies to ui-search too, then. The behavior seems to be the same at least.

Niels Erik Nielsen July 8, 2019 at 1:21 PM
Edited

but I don't really want to expand the API of <SearchAndSort>

stripes-force is contemplating refactoring the search and sort approach in profound ways anyway (like Charlotte's hinting at the end of her issue description).

Cate Boerema July 8, 2019 at 12:56 PM

this issue was going to serve as the technical task for fixing the underlying reset problem. If the repro steps define this too narrowly, please modify

Done

Details

Assignee

Reporter

Tester Assignee

Labels

Priority

Story Points

Sprint

Development Team

Prokopovych

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created July 2, 2019 at 12:33 PM
Updated August 9, 2019 at 11:39 AM
Resolved July 16, 2019 at 2:13 PM
TestRail: Cases
TestRail: Runs