Permissions: Users App Icon Displaying for Users with No Permissions
Description
CSP Request Details
CSP Rejection Details
Potential Workaround
is blocked by
is cloned by
relates to
Checklist
hideTestRail: Results
Activity
Mike Taylor April 17, 2017 at 11:30 PM
The manifestation as a permission derives from Cate's impression that UI modules would not be available if you didn't have any of the necessary permissions to meaningfully use them. We could have used something basic like users.collection.read
, or whatever it's called this week; but the general consensus was that it would be better to make a specific permission that meant exactly "may use the Users UI module".
Jason Skomorowski April 17, 2017 at 11:26 PM
I wonder if which apps to display for which roles is more of a client-configuration thing to be persisted in the configuration module rather than a server-side permission?
There isn't necessarily a 1:1 correspondence between client and server pieces and we're also dealing with the users interface rather than mod-users in particular and even ui-users could be replaced (eg. some other UI module could be at /users instead and it would more or less work with items provided the links line up)
Mike Taylor April 17, 2017 at 11:23 PM
That is generally true. However the module.NAME.enabled
permissions are, as far as I know, the only ones that have no server-side implementation at all. They are only meaningful as giving permission to access specific UI modules.
Jason Skomorowski April 17, 2017 at 11:20 PM
The reason it's only partially fixed is that you can still rig the system |
...but this is client-side code, it's not providing any security, it's just providing a better UX by not displaying elements that will error out and break due to lack of permissions.
Overview: If I haven't been given any rights within Users, the User app icon should not display.
Steps to repro:
Log into http://folio-uidemo.aws.indexdata.com/ as diku admin
Create or modify a user so that they have no assigned permissions within Users (I am still unclear as to which of the permissions in the menu map to the users app so I just removed all permissions)
Log out and log back in as the user with no permissions
Expected results: User app icon should not display
Actual results: User app icon displays