Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Factor generalised path function out of Users and Items module

Description

The path function is presently the biggest single hunk of code that differs between the Users and Items module. Yet in outline, it is the same in both places. We can extract the common core, and curry that as required into the module-specific version that each requires.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike TaylorMarch 14, 2017 at 5:15 PM

I created this function, and made it available in stripes-components. It's documented here: https://github.com/folio-org/stripes-components/blob/master/util/README.md#makepathfunctionbasepath-findall-querytemplate-sortmap-filterconfig

I released v0.1.0 of stripes-components with this included. (It is the first 0.x-series release, as opposed to 0.0.x – I think we are now stable enough to risk a little more light.)

I upgraded both ui-users and ui-items to require v0.1.0 of stripes-components, and to use its makePathFunction function. They are now both gratifyingly shorter and clearer.

Done

Details

Assignee

Reporter

Labels

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created March 14, 2017 at 3:50 PM
Updated March 14, 2017 at 9:59 PM
Resolved March 14, 2017 at 5:16 PM
TestRail: Cases
TestRail: Runs

Flag notifications