Manifest templating doesn't work for local resources

Description

In our first real-world application of local resource substitution, Matt found it ...doesn't actually work.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

blocks

Checklist

hide

TestRail: Results

Activity

Show:

Jason SkomorowskiMarch 8, 2017 at 3:00 AM

Turns out the ownProps we were getting in react-redux's mapDispatchToProps somewhat sensibly doesn't yet include the results of mapStateToProps and so the fix that prevented us from always having to pass this.props to mutators turned out to be incomplete.

Luckily that data is available from the store, unfortunately it's not in quite the right shape. I made a somewhat ungainly fix that iterates through the keys of the every time substitution is attempted and made to document the need to structure things better.

Done

Details

Assignee

Reporter

Labels

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created March 8, 2017 at 2:45 AM
Updated April 6, 2017 at 8:26 PM
Resolved March 8, 2017 at 3:00 AM
TestRail: Cases
TestRail: Runs