Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Fix stripes-connect so mutator invocations do not need to pass props in

Description

At present, the solution to STRIPES-122 requires application code to explicitly pass the component properties into mutators:

this.props.mutator.users.POST(data, this.props);

It should not be necessary to pass this through.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike TaylorFebruary 22, 2017 at 4:39 PM

... but it turns out that we do not need https://folio-org.atlassian.net/browse/STRIPES-205#icft=STRIPES-205 for this, because we can get the current component's props into the mapDispatchToState function via the little-used optional second parameter ownProps. I've updated stripes-connect to do this, and pass those props down into the mutators. It works fine, now, when the user-editing mutator invocation in Users.js has its second parameter ({{this.props}{) removed. So we're done here.

Mike TaylorFebruary 22, 2017 at 4:37 PM

The obvious way to solve this is by having the location object in the Redux store, so the mutators can access it from there instead of needing props. https://folio-org.atlassian.net/browse/STRIPES-205#icft=STRIPES-205 is about making that happen.

Mike TaylorFebruary 22, 2017 at 4:36 PM

This is the only thing preventing us from closing https://folio-org.atlassian.net/browse/STRIPES-122#icft=STRIPES-122.

Done

Details

Assignee

Reporter

Labels

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created February 22, 2017 at 4:36 PM
Updated February 24, 2017 at 11:23 PM
Resolved February 22, 2017 at 4:40 PM
TestRail: Cases
TestRail: Runs

Flag notifications