Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Multiple eslint errors on master branch

Description

Reconcile errors reported by eslint on master branch of stripes-core. Details below.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Charles LowellOctober 5, 2017 at 6:45 PM

However, if the stack trace is to be believed, then it is using the `eslint` version in `/home/jenkins/stripes-core/node_modules/eslint`

Charles LowellOctober 5, 2017 at 6:43 PM

Charles LowellOctober 5, 2017 at 6:42 PM

Yes, although we do have a broken eslint rule on master, which I've fixed.

to run the local version, we should be running `yarn lint`. If that's what's already happening, then perhaps trying `node_modules/.bin/eslint src || true`

Jeffrey CherewatyOctober 5, 2017 at 6:34 PM

Is Jenkins maybe using a global installation of `eslint` instead of the one installed locally by `eslint-config-stripes`? I agree that this does appear to be a configuration problem, not broken ESLint rules.

Mike TaylorOctober 5, 2017 at 5:03 PM

Looks more like a problem with ESLint configuration than with stripes-core.

Done

Details

Assignee

Reporter

Labels

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created October 5, 2017 at 4:52 PM
Updated October 6, 2017 at 2:31 PM
Resolved October 6, 2017 at 2:31 PM
TestRail: Cases
TestRail: Runs