For JS the code style will be checked by importing new project: stripes-eslint that will include the code style. For Java we want to rely on the code style enforced by SQ (we need to verify if it's aligned with our style).
Linting via ESLint is enabled across all relevant front-end projects.
Mike TaylorOctober 4, 2017 at 9:19 PM
stripes-react-hotkeys is a special case, and we should make no changes to it. It's a fork of the regular react-hotkeys which we had to make because its maintainer ignores PRs. We made only the changes we absolutely needed, and otherwise want to keep it as close to the original as possible.
John MalconianOctober 4, 2017 at 8:01 PM
ui-requests, ui-organization, ui-users, and stripes-core report lint errors. stripes-react-hotkeys has no linting set up. All other relevant client-side modules are now "lint-enabled" in the CI. Will create separate jira issues for outstanding client-side repos.
Mike TaylorSeptember 28, 2017 at 8:49 PM
By all means – feel free to rip out the || true wherever you see it.
John MalconianSeptember 28, 2017 at 8:43 PM
@Mike Taylor I can go with that. I only request that we lose '|| true' and I will be good to go!
For JS the code style will be checked by importing new project: stripes-eslint that will include the code style. For Java we want to rely on the code style enforced by SQ (we need to verify if it's aligned with our style).