Mitigate redux-form console noise in the interim until we upgrade

Description

redux-form is making a lot of noise in the console as a result of the way we have decoupled stripes-components from it. Jeffrey submitted some PRs to the project to address this which have been merged but only released in the 8.x branch.

https://github.com/erikras/redux-form/pull/4041
https://github.com/erikras/redux-form/pull/4103

8.x requires react-redux 6.x which we are unlikely to be able to upgrade to easily owing to how heavily stripes-connect leans on that API.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Mike Taylor December 16, 2020 at 4:51 PM

Ah, right — because the `redux-form` we want to have included was obtained from GitHub rather than an NPM release. Makes perfect sense.

Zak Burke December 16, 2020 at 4:42 PM

  1. we need uglify-webpack-plugin because the yarn build step fails without it.

  2. we need yarn build because stripes depends on build artifacts of redux-form, not on its source code. This is analogous to running make install (or sudo apt-get install ..., etc) to install shared libraries like APR and whatever you need for PCRE in mod-rewrite before you compile apache (something else I used to do in the previous millennium).

Mike Taylor December 16, 2020 at 2:43 PM

Yep, I got com from CVS, too!

Come to think of it, why do we even need yarn build? Why doesn't it suffice for the desired version of redux-form to be in the workspace, so it gets picked up ahead of whatever else might be requested?

Zak Burke December 16, 2020 at 2:38 PM

, I don't remember why the uglify module was necessary, though I suspect redux-form wouldn't build properly without it.

I cleaned up the git instructions; thanks for noting that. co for checkout and ci for checkin/commit are left over from my CVS days last millenium.

Mike Taylor December 16, 2020 at 2:12 PM

Why is it necessary to yarn add uglifyjs-webpack-plugin?

BTW., your instructions say to use git co. I guess this an alias that you set up years ago and have got so used to using you don't even notice it any more, as I have done with git com for commit. But the instructions would be better and more explicit if you said to use git checkout.

Won't Do

Details

Assignee

Reporter

Priority

Development Team

Stripes Force

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created March 11, 2019 at 5:59 PM
Updated December 16, 2020 at 4:51 PM
Resolved July 4, 2019 at 1:40 AM
TestRail: Cases
TestRail: Runs