Should some currencies be excluded from drop-down list?
Description
Holly originally asked that currencies that aren't actually currencies a FOLIO library would use be excluded from the currency drop down list. It looks like gold, silver, etc. have been excluded, but others have not. Five examples are in attached file screenshot-1.png. My concern is that a library might select the wrong option, especially as related to US Dollar. US Dollar (Next day) (USN) appears above US Dollar (USD) (as shown in attached file currency-setting.jpg). If the person setting up the library selects the first one, they will have the wrong setting.
: Thanks for taking care of this! : I agree that we should be as inclusive as possible, but anything that really isn't a currency that is used by any library, and could be confused with one that is, should be excluded. Thanks!
Zak Burke June 17, 2019 at 1:26 AM
Yes, I excluded the 5 you mentioned. This change made it into stripes-components v5.4.2 and is included as part of the Q2.2 release.
Holly Mistlebauer June 16, 2019 at 11:24 PM
, it looks like you went ahead and added the 5 I mentioned to the exclusion list. Correct? That's all I have for now. When will the updated file be released? Thanks so much...
Ann-Marie Breaux June 13, 2019 at 7:18 AM
Getting rid of the odd USD one seems most important to me, and it looks like the additional ones you recommended are now excluded. I think we can go with the current exclusions, and then see if anyone has trouble during UAT. My inclination is to err on the side of inclusion, and only exclude if there's a clear reason to do so.
Zak Burke June 13, 2019 at 2:05 AM
We get the list of currencies from a third-party library so that we don't have to maintain the list. We manually exclude several values and can easily add additional exclusions, such as the five mentioned here. Here is the current list of exclusions:
Holly originally asked that currencies that aren't actually currencies a FOLIO library would use be excluded from the currency drop down list. It looks like gold, silver, etc. have been excluded, but others have not. Five examples are in attached file screenshot-1.png. My concern is that a library might select the wrong option, especially as related to US Dollar. US Dollar (Next day) (USN) appears above US Dollar (USD) (as shown in attached file currency-setting.jpg). If the person setting up the library selects the first one, they will have the wrong setting.