Add address type validation to AddressFieldGroup
Description
CSP Request Details
CSP Rejection Details
Potential Workaround
blocks
Checklist
hideTestRail: Results
Activity

Cate Boerema August 30, 2017 at 4:01 PM

Michal Kuklis August 30, 2017 at 3:55 PM
it looks like this works fine for existing users but not for the new users. I will try to fix it today.

Cate Boerema August 30, 2017 at 3:24 PM
I guess this could be related to the current problem with Users ...

Cate Boerema August 30, 2017 at 3:15 PM
Just going through demo candidates and it looks like this has regressed. I tested adding a new address to an existing user without an address type and also creating a new user without an address type. In both cases I got an error.
Adding new user error: ERROR: in module @folio/users, operation POST on resource 'users' failed, saying: Internal Server Error, Please contact System Administrator or try again
Adding new address to user error: ERROR: in module @folio/users, operation PUT on resource 'selUser' failed, saying: Internal Server Error, Please contact System Administrator or try again
Screencast of repro: https://www.screencast.com/t/j49PiogHWGnE

Charlotte Whitt August 21, 2017 at 9:32 PMEdited
Manual test in FOLIO test http://folio-testing.aws.indexdata.com/ version @folio/users 2.9.100474 , using Chrome
When adding an address to a given user, and the address type is not selected, then a message will pop up saying "Address type is required". When the address type is defined, and the update is saved, and all is now good.
I'll close the issue as done.
Observation:
If the the selected Address type, is a type already defined for another address for this specific user, then I get an error message, and my input is lost. I'll file a separate bug for this.
Okay, Michal clarified that this was probably never working properly on the Create and Edit modes of the users page (he had fixed in the View mode). Given that, I am going to reclose this one. I am not going to create a new bug writeup just yet. I think we should let UX do their review of this component and work out any remaining issues once we've gotten their redesign. .