Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Unique IDs for editable authority list buttons

Description

Currently the automated tests look for the button in authority lists by button label. This is brittle due to the buttons labels being subject to change.

Would be great if we could give them unique ID's

In the context of the button, do we now the name of the list it applies to? Then it could be

id="clickable-patrongroup-add"

If we don't know the particular list here, could we then assign the surrounding container id="authority-list-patrongroup" ?

But if we ever had multiple authority lists in the same page, then merely assigning the button within that container the id="clickable-add" would break, I guess.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

John Coburn February 14, 2018 at 8:28 PM

Closing this guy for now... EditableList should have all of the ID's that it needs...

John Coburn January 18, 2018 at 8:13 AM
Edited

, some good news - as part of https://github.com/folio-org/stripes-components/pull/191, unique Id's will be supplied to the clickables in anything that uses an `<EditableList>` (including <AuthorityList>) It takes a supplied 'id' prop and generates ids for all of its internal clickables in a naming conventions similar to what you've mentioned.

Done

Details

Assignee

Reporter

Labels

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created August 17, 2017 at 9:09 AM
Updated November 20, 2019 at 9:20 AM
Resolved February 14, 2018 at 8:28 PM
TestRail: Cases
TestRail: Runs