Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Edit Icon Won't Support Right Click and Open in New Tab

Description

Steps to Repro:

  1. Log into folio-testing

  2. Go to Users and click on a user record

  3. Right click the edit icon

Expected: Should have standard browser options for a link including right click to open in new tab. This should work for any record with an edit button/icon in FOLIO

Actual: Doesn't have these options

Additional Info: The edit page does now have it's own URL (per FOLIO-941)

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Rasmus Wølk January 18, 2018 at 9:31 PM

Rasmus Wølk January 18, 2018 at 1:04 AM

This pull-request adds the option for href on the IconButton: https://github.com/folio-org/stripes-components/pull/193

Rasmus Wølk January 17, 2018 at 11:00 PM

Definitely. I’ll add that ASAP.

John Coburn January 17, 2018 at 9:03 PM
Edited

<IconButton> needs to be handy, like <Button> so if it gets an `href` prop, it can render a <Link> or <a>, what do you think, ?

Zak Burke January 15, 2018 at 1:11 AM

For accessibility reasons, that icon is a button rather than a link, and browsers do not support right-click-new-tab for buttons. It should be possible to change the icon to link instead of a button, and add additional accessibility markup. , any thoughts on how best to proceed here?

We should use the same pattern for all icons in the panel-header bar (+New, Edit, Clone, etc.).

Done

Details

Assignee

Reporter

Labels

Priority

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created December 15, 2017 at 11:01 AM
Updated January 18, 2018 at 9:31 PM
Resolved January 18, 2018 at 9:31 PM
TestRail: Cases
TestRail: Runs