Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Infinite Scroll Part 3

Description

  • fix showing/hiding of columns with new value for 'visibleColumns' prop

  • assure 'rowFormatter' function receives all of the necessary arguments that it needs (width, and columnWidths)

  • appropriately apply the 'columnWidths' prop.

  • fix/adjust browser-based 'blue-border' style.

  • examine multiple item selection (duplicate data?) (See Screenshot) (paging issue: MODUSERS-21)

  • scrollbar flickering/ optimize component updates.

Environment

None

Potential Workaround

None

Attachments

2

Checklist

hide

TestRail: Results

Activity

Show:

Mike Taylor June 23, 2017 at 3:19 PM

Sounds good, Craig! Please rebase your branch on current master, and present a pull-request.

Craig McNally June 23, 2017 at 3:17 PM

Not sure how this typically works... I fixed the infinite scroll for items locally as this was something we wanted to get working sooner rather than later, and was wondering what the process is to roll the change back into FOLIO... I see http://dev.folio.org/community/contrib-code but wasn't sure if there was anything else that I needed to do since this is part of an issue that is actively being worked on. I figured I'd ask before going any further.

FWIW I based the fix on ui-users/Users.js and consists of maybe a dozen LOC.

Craig McNally June 20, 2017 at 3:55 PM
Edited

I'm not seeing the infinite scroll on items, even with ~4k items... (See screen shot) I'm using ui-items 1.6.0.

John Coburn June 13, 2017 at 5:49 PM
Edited

Infinite scroll is active on Items... just needs more records to make it work!

The component only knows about the size of the data that's coming into it - it *should pop back to the top of the list when smaller result set comes in. If not, then there's a bug we can include on this issue...
It has a method that can be called via a ref: .backToTop() that the application can use OR we could use the possibly-not-working-yet prop scrollToIndex = 0... but I'm not entirely sure that props are the best way to handle it.

Jason Skomorowski June 13, 2017 at 1:02 AM

Oh, FYI, I'm pretty sure we didn't enable infinite scroll for items? Unnoticed due to lack of items.

Done

Details

Assignee

Reporter

Labels

Priority

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs
Created June 9, 2017 at 1:55 PM
Updated July 20, 2017 at 12:29 PM
Resolved July 20, 2017 at 12:29 PM
TestRail: Cases
TestRail: Runs