Incorrect errors count

Description

Overview:
The issue was spotted during testing . The amount of instance errors is calculated as 1 when in fact multiple incoming records fail during instance creation (https://bugfest-orchid.int.aws.folio.org/data-import/job-summary/936c8e98-b37c-4876-a368-88b39eda54b4). The issue is only relevant for the calculation of instance errors (e.g. for holdings it works as expected).

Steps to Reproduce:

Scenario 1:

  1. Import the attached 3 no titles.mrc file using "Default - Create instance and SRS MARC Bib" job profile.
    The attached file has 3 records that don't contain the 245 field, which is responsible for the instance title and is causing the instance creation error.

  2. Wait for import completion with errors and check instance errors count at the summary table at top of the individual import job's log.

Expected Results:
The amount of instance errors is indicated as 3 at the "Instance" and "Error" columns because each of 3 incoming records fails to create an instance.

Actual Results:
The amount of instance errors is indicated as 1 at the "Instance" and "Error" columns (

).

 

Scenario 2:

1. Create and save field mapping profile for holdings with the following values:

  • Name - any unique value

  • Incoming record type - MARC Bibliographic

  • FOLIO record type - Holdings

  • Permanent - 901$a

2. Create action profile for creating Holdings

3. Create job profile with:

  • "Default - Create instance and SRS MARC Bib"

  • Created action profile for holdings 

4. Import the attached "A_file.mrc" file using created job profile

Expected Results:
The amount of holdings errors is indicated as 5 at the "Holdings" and "Error" columns because each of 5 incoming records fails to create an holdings.

Actual Results:
The amount of holdings errors is indicated as 1 at the "Holdings" and "Error" columns

 

Scenario 3:

1. Create and save field mapping profile for holdings with the following values:

  • Name - any unique value

  • Incoming record type - MARC Bibliographic

  • FOLIO record type - Holdings

  • Permanent - select any value from the list

2. Create and save field mapping profile for item with the following values: 

  • Name - any unique value

  • Incoming record type - MARC Bibliographic

  • FOLIO record type - Item

  • Material type - 902$a

  • Permanent loan type - select any value from the list

  • Status - Available

3. Create action profile for creating Holdings

4. Create action profile for creating Item

5. Create job profile with:

  • "Default - Create instance and SRS MARC Bib"

  • Created action profile for holdings 

  • Created action profile for item

6. Import the attached "A_file.mrc" file using created job profile

 

Expected Results:
The amount of item errors is indicated as 5 at the "Item" and "Error" columns because each of 5 incoming records fails to create an item.

Actual Results:
The amount of item errors is indicated as 1 at the "Item" and "Error" columns

 

Scenario 4:
 The counter for the 'Invoice' column in the 'No action' and 'Error' rows is incorrect. Steps for reproducing: 

1. Go to Settings application/Data import/Field mapping profiles and find the Default - EBSCO serials invoice profile.

Click Actions/Duplicate

2. Update the new copy of the profile as follows:

  • Name: Test invoice log table Create EBSCO invoice

  • Batch group: Select any value from the dropdown list

  • Vendor invoice number: BGM+380+[1]

  • Vendor name: EBSCO SUBSCRIPTION SERV (search and select via Organization look-up) or other of the accepted values

  • Accounting code: "G64758-74837" or other of the accepted values

  • Payment method: Select any value from the dropdown list

Save and close

3. Go to the "Action profiles" section/Actions/New action profile
Create a new "Action Profile" with:

  • Name: Test invoice log table (or unique valid name)

  • Action: create

  • FOLIO record type: Invoice.

Link the profile with field mapping profile from step 2

Press Save and close

4. Go to the "Job profiles" section/Actions/New job profile
Create a new "Job profile" with

  • Name: Test invoice log table (or unique valid name)

  • Accepted data type: EDIFACT

Click + and link the above action profile

Press Save and close

5. Go to the "Data Import" application->Click on the "or select files" button -> Select the "test_table_Invoice.edi" file (attached to this test) -> click the "Open" button

6. Select "Test invoice table" job profile->Actions->Run and then confirm that you want to run the import.

7. Wait for the import to finish, and check the status message for the file that was imported from step  #5.

8. Click on the file name in "File name" column for the file from step #5.

9. Check the "Log summary" table to see the results on the import job.

10. Pay attention on the amount of 'No action' and 'Error' quantity in the 'Summary' table.

Scenario 5:

And the issue with counter is with importing order:

  1. Go to "Settings" application -> Select "Data import" setting -> Select "Field mapping profiles" -> Click "Actions" button -> Click "New field mapping profile" option.

  2. Populate following fields:

  •  

    • "Name*" field - enter unique name (eg. Test Order)

    • "Incoming record type*" dropdown - select "MARC Bibliographic" option

    • "FOLIO record type*" dropdown - select "Order" option

    • "Purchase order status" select "Pending" option

    • "Approved" checkbox - Checked

    • "Vendor*" field - select "GOBI Library Solutions" option via the "Organization look-up" option link

    • "Re-encumber" mappable checkbox - select "false" option

    • "Title*" field - enter "245$a"

    • "Must acknowledge receiving note" mappable checkbox - select "false" option

    • "Publication date" field - enter "264$c; else 260$c"

    • "Publisher" field - enter "264$b; else 260$b"

    • "Edition" field - enter "250$a"

    • "Internal note" field - enter "981$d"

    • "Acquisition method*" mappable checkbox - select "Purchase At Vendor System" option

    • "Order format*" mappable checkbox  - select "Physical Resource" option

    • "Receipt status" mappable checkbox - select "Pending" option

    • "Payment status" mappable checkbox - select "Pending" option

    • "Selector" field - enter "981$e"

    • "Cancellation restriction" mappable checkbox  - select "false" option

    • "Rush" mappable checkbox  - enter "981$h"

    • "Receiving workflow*" mappable checkbox  - select "Synchronized" option

    • "Account number" field - enter "981$g"

    • "Physical unit price" field - enter "980$b"

    • "Quantity physical" field - enter "980$g"

    • "Currency*" mappable checkbox - select "USD" option

    • "Material supplier" - select "GOBI Library Solutions" option via the "Organization look-up" option link

    • "Create inventory" mappable checkbox - select "Instance, Holding, Item" option

    • "Material type" mappable checkbox - select "book" option

    • "Create inventory" (E-resources details accordion) mappable checkbox  - select "None" option.

  1. Click "Add Contributor" button and populate following:

  •  

    • "Contributor" field - enter "100$a"

    • "Contributor type" mappable checkbox - select "Personal name" option.

  1. Click "Add Product ID and product ID type" button and populate following:

  •  

    • "Product ID" field - enter "020$a"

    • "Qualifier" field - enter "020$q"

    • "Product ID type" mappable checkbox - select "ISBN".

  1. Click "Add vendor reference number" button and populate following:

  •  

    • "Vendor reference number" field - enter "980$f"

    • "Vendor reference type" mappable checkbox  - select "Vendor order reference number" option.

  1. Click "Add fund distribution" button and populate following:

  •  

    • "Fund ID" mappable checkbox  - enter "981$b"

    • "Expense class" mappable checkbox - enter "981$c"

    • "Value" field - enter "100"

    • "Type" - select "%".

  1. Click "Add location" button and populate following:

  •  

    • "Name (code)" field - enter "049$a"

    • "Quantity physical" field - enter "980$g".

  1. Click "Add volume" button and populate following:

  •  

    • "Volume" field - enter "993$a".

  1. Click "Save as profile & Close" button.

  2. Click on "Action profiles" section on the second "Data import" pane > Click on the "Actions" button> "New action profile" button.

  3. Populate following fields:

  •  

    • "Name" - Test Order (or any unique value)

    • "Action" - Create (all records except MARC Authority or MARC Holdings)

    • "FOLIO record type" - Order

    • Link the Test Order (created in step 3).

  1. Click "Save as profile & Close" button.

  2. Click on "Job profiles" section on the second "Data import" pane > Click on the "Actions" button> "New job profile" button.

  3. Populate following:

  •  

    • "Name" - Test Order(or any unique valid name)

    • "Accepted data type" - MARC

    • Overview:
      Attach the action profile Test Order (created in step 6).

  1. Click "Save as profile & Close" button.

  2. Go to the "Data import" app-> Click on the "or choose files" button -> Select file from the precondition -> click on the Open button.

  3. Select the "Test Order" job profile (from step 4) > Click on the "Actions" button> Select "Run" > Click on the "Run" button at the displayed modal.

  4. After the import is completed, click on the file name at the top of the log list.

  5. Pay attention on the amount of 'Created' quantity in 'Orders' column in the 'Summary' table.

 
 

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

11

Checklist

hide

TestRail: Results

Activity

Show:

Kateryna SenchenkoDecember 21, 2023 at 4:35 PM

Hi , , the ticket was tested on bugfest and I'm closing it, please let me know if there is something else required. Thank you!

Ann-Marie BreauxDecember 4, 2023 at 5:30 PM

Issue is only with Snapshot, and only affects Quesnelia, per . Will be fixed by tomorrow. In the meantime, moving this to Awaiting release, since it should be OK on Bugfest

Ann-Marie BreauxDecember 4, 2023 at 5:57 AM

Hi and I tried to test on Snapshot and Snapshot-2, but I can't get holdings records to create. I added a note for on Slack - not sure what the heck is going on. I'm keeping this In review until we figure it out. Thanks, A-M

Tetiana ParanichNovember 29, 2023 at 8:03 AM

Hi ! Works as expected on https://folio-snapshot.dev.folio.org

See the attached

,

,

,

 

Javokhir AbdullaevNovember 20, 2023 at 2:57 PM

Hi   and , Ruslan told me that, invoices are displayed like that, and what we see below of the total counters are lines of records, so in fact, total errors and other properties are being displayed correctly. 

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Folijet

Fix versions

Release

Poppy (R2 2023) Bug Fix

RCA Group

Legitimate regression

Affected releases

Orchid (R1 2023)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created April 21, 2023 at 2:40 PM
Updated February 26, 2024 at 2:23 PM
Resolved December 4, 2023 at 5:31 PM
TestRail: Cases
TestRail: Runs