Replace Future<Boolean> by Future<Void>

Description

The underlying problem of the bug MODPUBSUB-210:

Future<Boolean> is used with true indicating success and false indicating failure. This results in two ways how a failure can be propagated: As a failing Future, or as a succeeding Future returning false. This results in bloated code and is error-prone.

The idiomatic way is to only use the built-in success/failure indicator of the Future and to use Void as the type: Future<Void>.

Task: Replace Future<Boolean> by Future<Void> and use the built-in error handling of Vert.x' Future: https://github.com/folio-org/raml-module-builder/blob/master/doc/futurisation.md#result-and-error-handling

This is an umbrella to split this task into smaller chunks.

Environment

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:
Done

Details

Assignee

Reporter

Labels

Priority

Story Points

Sprint

Development Team

Vega

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created January 21, 2022 at 11:06 PM
Updated March 10, 2022 at 2:48 PM
Resolved March 10, 2022 at 2:48 PM
TestRail: Cases
TestRail: Runs