Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Incorrect status for tenant init

Description

When mod-pubsub gets an error from mod-permissions on tenant init when it creates a pubsub user, it still returns OK.

Expected behavior: fault, so the administrator can know that something is wrong.

See attached okapi.log.

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Attachments

1

Checklist

hide

TestRail: Results

Activity

Show:

Julian LadischJanuary 21, 2022 at 8:52 PM

I approve this change.

However, it doesn't fix the underlying problem:

Future<Boolean> is used with true indicating success and false indicating failure. This results in two ways how a failure can be propagated: As a failing Future, or as a succeeding Future returning false. This results in bloated code and is error-prone.

The idiomatic way is to only use the built-in success/failure indicator of the Future and using Void as the type: Future<Void>.

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Core: Platform

Fix versions

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created January 20, 2022 at 11:24 AM
Updated January 24, 2022 at 10:32 AM
Resolved January 22, 2022 at 4:18 PM
TestRail: Cases
TestRail: Runs