Allowed service points: switch to mod-circulation-bff

Description

When ECS TLR feature is enabled, mod-patron’s allowed SP endpoints (GET /patron/account/{requesterId}/instance/{instanceId}/allowed-service-points, GET /patron/account/{requesterId}/item/{itemId}/allowed-service-points) need to use mod-circulation-bff’s endpoint implemented in (GET /circulation-bff/allowed-service-points) instead of mod-circulation endpoints.

Note. mod-circulation-bff will check whether ECS TLR enabled too, but mod-circulation-bff won’t be deployed for anyone except LoC in R and mod-patron shouldn’t call it if it doesn’t need to.

Feature toggle. There is a setting in circulation settings that tells mod-patron whether it needs to request allowed service points from mod-circulations directly or from mod-circulation-bff. This adds two dependencies - 1) circulation settings interface (in master already) 2) mod-circulation-bff - will not be released for community in R, dependency on its interface needs to be optional.

Environment

None

Potential Workaround

None

Attachments

13

Checklist

hide

Activity

Show:

Antony Hruschev October 30, 2024 at 12:08 PM

Cases with combination of ecsTlrFeature between mod-tlr and mod-circulation-storage:
Data for testing:

 


1. tlr - exits - false:

 

 

  1. tlr - exists -true:

 

 

  1. tlr - null - circualtion-storage - false (non valid case, but has been checked) :

 

 

  1. tlr - null - circualtion-storage - true (non valid case, but has been checked) :

 

 

 

Done

Details

Assignee

Reporter

Priority

Story Points

Sprint

Development Team

Vega

Fix versions

Release

Ramsons (R2 2024)

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created August 2, 2024 at 1:06 PM
Updated October 30, 2024 at 2:56 PM
Resolved October 14, 2024 at 3:13 PM
TestRail: Cases
TestRail: Runs