R1 Hotfix -> R2 Bugfix - Unopen fails after a rollover for an order created in the previous year

Description

Overview:

It looks like the current unopen strategy is updating encumbrances for the previous fiscal year when an order is unopened, changing old budgets. It should only be taking the current fiscal year into account when processing encumbrances.

Steps to Reproduce:

  1. Log into some FOLIO environment as User X

  2. Create a Fiscal year, Ledger and Fund with a budget

  3. Create an order with 1 POL with 1 fund distribution for that budget

  4. Open the order

  5. Create a second fiscal year in the same series

  6. Rollover ledger allocations and all order based on remaining encumbrances

  7. Edit fiscal years so that FY 2 is now the current fiscal year

  8. Navigate to your order

  9. Click unopen in action menu

Expected Results: Order is moved to pending state and FY 2 encumbrance is pending. FY 1 encumbrance has NOT been changed in any way.

Actual Results: Multiple pending encumbrances appear on the budget for the order.

Additional Information:

When unopening an order, OpenToPendingEncumbranceStrategy uses EncumbranceService#getOrderEncumbrances to get the list of related encumbrances, so it is not taking the fiscal year into account. See EncumbranceService#getCurrentPoLinesEncumbrances for an example of a query taking the current fiscal year into account.
**

CSP Request Details

None

CSP Rejection Details

None

Potential Workaround

None

Checklist

hide

TestRail: Results

Activity

Show:

Dennis BridgesAugust 6, 2021 at 8:35 PM

test successful in bugfest-juniper

Dennis BridgesAugust 5, 2021 at 3:12 PM

test successful in folio-testing

AnyaAugust 2, 2021 at 2:45 PM

Support -  thank you for your explanation.  

Victoria_SmelovaAugust 2, 2021 at 2:30 PM

 we cannot close this story.
We have two separate items   (for R1 Iris) and   (for R2 Juniper) to fix the same issue but on two different code bases of two different releases. These two fixes must be also deployed to different bugfest envs and tested in corresponding releases, which cannot be done within one story.

AnyaAugust 2, 2021 at 2:14 PM
Edited

SUpport -  if this story is a dup - can you close it and add a support label to the other tickets you mention above?

Done

Details

Assignee

Reporter

Tester Assignee

Priority

Story Points

Sprint

Development Team

Thunderjet

Fix versions

Release

R2 2021 Bugfix

Affected Institution

Lehigh
MI State University/Library of Michigan
MO State
University of Tennessee Martin

TestRail: Cases

Open TestRail: Cases

TestRail: Runs

Open TestRail: Runs

Created July 19, 2021 at 11:51 AM
Updated December 6, 2023 at 10:52 PM
Resolved August 5, 2021 at 3:12 PM
TestRail: Cases
TestRail: Runs